Unmount filesystem before dropping to fail early if filesystem is busy (

#180)
outofforest · Aug 24, 2022 · 695eb48 · 695eb48
1 parent c2200dc
commit 695eb48
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/infra/storage/zfs.go b/infra/storage/zfs.go
@@ -250,6 +250,15 @@ func (d *zfsDriver) Drop(ctx context.Context, buildID types.BuildID) error {
 	if err != nil {
 		return errors.WithStack(fmt.Errorf("build %s does not exist: %w", buildID, types.ErrImageDoesNotExist))
 	}
+	mounted, _, err := filesystem.GetProperty(ctx, "mounted")
+	if err != nil {
+		return err
+	}
+	if mounted == "yes" {
+		if err := filesystem.Unmount(ctx); err != nil {
+			return err
+		}
+	}
 
 	if err := filesystem.Destroy(ctx, zfs.DestroyRecursive); err != nil {
 		return errors.WithStack(fmt.Errorf("build %s have children: %w", buildID, ErrImageHasChildren))