-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong footer links (and copyright) #88
Comments
The generic links make sense, but I'm not sure about the copyright part. |
Original issue: openedx/wg-build-test-release#348 |
While I agree that the footer links in the Indigo footer must be improved (and in some cases: fixed), can we have a discussion about the "official" list of links that should be included? In particular:
|
@mariajgrimaldi if you feel we should replace the footer links, can you confirm which ones these should be? |
I don't think footer links should change, mainly because it's a design decision for every theme designer. The official redwood test sheet specifies a few tests regarding themes, which include:
Since this is the default theme for the Open edX release sandbox, testers follow those descriptions to test so this kind of issue is raised. Therefore, I think we should discuss whether the default theme should follow the "official" standard or a new one, so we can update those tests accordingly. Where do you think we should have this discussion? |
Let's have this discussion here. Alternatively, if there is no consensus, we can have a live conversation about it. The disagreement is about the following items:
Am I missing something? I'd like to argue that these items are actually improvements for most people over the previous, default theme. In particular, the copyright notice is unnecessary because the theme does not mention Open edX anywhere. Well, there is the "powered by Open edX" image but it links straight to open.edx.org, and so there is no need to specify that copyright. For comparison, notice that the official Wordpress theme does not include a copyright notice: https://wordpress.org/themes/twentytwentyfour/preview/ If the test sheet is supposed to test the default theme, then we should disable Indigo in testing. But I think that would be a huge loss. Instead, I propose that we amend the two tests the following way:
|
I'm investigating re: the copyright statement.... |
Expected behavior
Footer includes seven (7) links, namely About, Blog, Contact, Donate, Terms of Service & Honor Code, Privacy Policy, Take free online courses at edX.org. All links must be working.
Actual behavior
Actual links are:
About Us Blog Donate Terms of Sevice Privacy Policy Help Contact Us
This is at https://redwood.demo.edly.io/
Steps to reproduce
Go to https://redwood.demo.edly.io/
Scroll down.
Additional information
TC_LEARNER_48 also fails, as copyright notice also does not match. Supposed to be “All rights reserved except where noted. edX, Open edX and their respective logos are registered trademarks of edX Inc.” and instead it's "Copyrights ©2024. All Rights Reserved."
The text was updated successfully, but these errors were encountered: