Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: let the platform decide for login and registration #91

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

CodeWithEmad
Copy link
Member

This will

  • Removes the force to using authn mfe for login and registration
  • Removes trailing whitespaces
  • Fixes some typos

@hinakhadim
Copy link
Collaborator

Thanks for the PR. I have tested with normal auth flow and it's working fine. Could you please elaborate on the following questions related to tpa:

  • For the third-party auth logic, if I added the tpa slug, will it take me to the tpa page directly?
  • Why is there a need to add tpa in authn mfe when one can directly go to the tpa page?

If you can share a working video of it with TPA, it will greatly help me understand the flow with TPA. or let me know how to test tpa on my system. For now, I've added FEATURES['THIRD_PARTY_AUTH_HINT'] = 'oa2-google' in settings. But unable to test TPA flow as I am expecting that there will be more configurations to setup.

@CodeWithEmad
Copy link
Member Author

CodeWithEmad commented Jun 14, 2024

For the third-party auth logic, if I added the tpa slug, will it take me to the tpa page directly?

Yes, you can test if you have a TPA setup and add "THIRD_PARTY_AUTH_HINT": "some-provider-slug", inside SiteConfiguration (it takes up to 3 minutes to update because of the cache) or have it directly in settings with a plugin.

Why is there a need to add tpa in authn mfe when one can directly go to the tpa page?

I don't get it. OpenedX covers all sorts of scenarios and all of them are handled with login/register views. in this scenario, it's not possible if you want users to not interact with authn mfe and use your desired TPA directly (Good UX). Instead, you need to let them know that after login, you need to click on another button to login (Bad UX)

Here is a video of SAML login setup on one of our test orgs.

Screencast.from.06-14-2024.02.12.27.PM.webm

@hinakhadim
Copy link
Collaborator

Awesome! Thanks a lot for sharing the video. It clears things up much better.

I'll appreciate it if you could do the below tasks in this PR.

  1. Move the Register button condition before signing in button. It is better to place the sign-in button after the register button.
  2. Add a changelog entry.

@CodeWithEmad
Copy link
Member Author

No Problem.

@CodeWithEmad CodeWithEmad force-pushed the chore/cleanup branch 3 times, most recently from 8ceaba2 to 87f11f6 Compare June 14, 2024 12:56
@CodeWithEmad
Copy link
Member Author

Here you go.

We force users to go to authentication mfe for login/registration and prevent login behavior tweaks like having THIRD_PARTY_AUTH_HINT in your site configuration which redirects users to a TPA when they visit /login.

Close overhangio#87
@hinakhadim hinakhadim merged commit 5c06fff into overhangio:master Jun 20, 2024
1 check passed
@CodeWithEmad CodeWithEmad deleted the chore/cleanup branch June 20, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants