Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New user #172

Merged
merged 2 commits into from
Sep 3, 2024
Merged

New user #172

merged 2 commits into from
Sep 3, 2024

Conversation

dylanratcliffe
Copy link
Member

No description provided.

Copy link

github-actions bot commented Sep 3, 2024

mapped Expected Changes

replaced ecs-task-definition › visit-counter-terraform-example
--- current
+++ planned
@@ -1,26 +1,26 @@
-arn: arn:aws:ecs:eu-west-2:540044833068:task-definition/visit-counter-terraform-example:6
-arn_without_revision: arn:aws:ecs:eu-west-2:540044833068:task-definition/visit-counter-terraform-example
-container_definitions: '[{"cpu":256,"environment":[{"name":"FACIAL_RECOGNITION_SERVICE","value":"face-terraform-example.overmind-terraform-example.com"}],"essential":true,"healthCheck":{"command":["CMD-SHELL","curl -f http://localhost:80 || exit 1"],"interval":30,"retries":3,"timeout":5},"image":"yeasy/simple-web:latest","memory":512,"mountPoints":[],"name":"visit-counter","portMappings":[{"appProtocol":"http","containerPort":80,"hostPort":80,"protocol":"tcp"}],"systemControls":[],"volumesFrom":[]}]'
+arn: (known after apply)
+arn_without_revision: (known after apply)
+container_definitions: '[{"cpu":256,"environment":[{"name":"FACIAL_RECOGNITION_SERVICE","value":"face-terraform-example.overmind-terraform-example.com"},{"name":"FACIAL_RECOGNITION_SERVICE_USER","value":"visit-counter"}],"essential":true,"healthCheck":{"command":["CMD-SHELL","curl -f http://localhost:80 || exit 1"],"interval":30,"retries":3,"timeout":5},"image":"yeasy/simple-web:latest","memory":512,"mountPoints":[],"name":"visit-counter","portMappings":[{"appProtocol":"http","containerPort":80}],"volumesFrom":[]}]'
 cpu: "256"
 ephemeral_storage: []
-execution_role_arn: ""
+execution_role_arn: null
 family: visit-counter-terraform-example
-id: visit-counter-terraform-example
+id: (known after apply)
 inference_accelerator: []
-ipc_mode: ""
+ipc_mode: null
 memory: "512"
 network_mode: awsvpc
-pid_mode: ""
+pid_mode: null
 placement_constraints: []
 proxy_configuration: []
 requires_compatibilities:
     - FARGATE
-revision: 6
+revision: (known after apply)
 runtime_platform: []
 skip_destroy: false
-tags: {}
-tags_all: {}
-task_role_arn: ""
+tags: null
+tags_all: (known after apply)
+task_role_arn: null
 terraform_address: module.scenarios[0].aws_ecs_task_definition.visit_counter
 terraform_name: module.scenarios[0].aws_ecs_task_definition.visit_counter
 track_latest: false

unmapped Unmapped Changes

Note

These changes couldn't be mapped to a discoverable cloud resource and therefore won't be included in the blast radius calculation.

updated aws_ecs_service › module.scenarios[0].aws_ecs_service.visit_counter
--- current
+++ planned
@@ -42,7 +42,7 @@
 service_registries: []
 tags: {}
 tags_all: {}
-task_definition: arn:aws:ecs:eu-west-2:540044833068:task-definition/visit-counter-terraform-example:6
+task_definition: (known after apply)
 terraform_address: module.scenarios[0].aws_ecs_service.visit_counter
 terraform_name: module.scenarios[0].aws_ecs_service.visit_counter
 timeouts: null

Blast Radius

items Items edges Edges
1 0

Open in Overmind

warning Risks

medium Potential Impact of ECS Task Definition Replacement [Medium]

The ECS task definition for visit-counter-terraform-example is being replaced. The new configuration introduces an additional environment variable: FACIAL_RECOGNITION_SERVICE_USER with the value visit-counter. The key risks and points to validate are:

  • Potential Impact on Services: Ensure that the newly added environment variable FACIAL_RECOGNITION_SERVICE_USER is correctly utilized by the application code. Failing to do so might lead to the application not functioning as expected.
  • Service Downtime: Replacing the ECS task definition could lead to temporary downtime. Validate if the new task definition has been tested in a staging environment before deployment to production.
  • Dependency Check: Validate that the service at face-terraform-example.overmind-terraform-example.com correctly handles requests with the new FACIAL_RECOGNITION_SERVICE_USER variable.

Validation Steps:

  • Check application logs for any errors related to the new environment variable.
  • Ensure the updated task definition has been deployed in a testing environment to observe any unusual behavior.
  • Validate connectivity to face-terraform-example.overmind-terraform-example.com and verify it acknowledges the FACIAL_RECOGNITION_SERVICE_USER correctly.

Failure to validate these elements could result in service disruptions.

medium Service Disruption Risk Due to ECS Service Update [Medium]

The ECS service visit-counter is undergoing an update where the task_definition attribute is set to be updated with a new revision. It is crucial to assess the reliability and stability of the updated ECS task definition as it may introduce temporary service disruptions.

  • Validation of Task Definition: Ensure that the new task definition configuration is tested and validated. The updated definition should correctly handle traffic without causing errors or application crashes.
  • Replica Management: Verify that the scheduling strategy and replica configuration remain consistent post-update, as any misconfiguration could result in improper task provisioning and service availability issues.
  • Integrated Testing: Prior to applying this change, execute thorough integrated testing to confirm the service maintains its functionality and performance with the new task definition.

Validation Steps:

  • Deploy the new task definition in a staging environment mimicking the production setup and monitor for any anomalies.
  • Validate that the EC2/FARGATE instances running the new task maintain network connectivity and performance.
  • Ensure the health check configurations in the new task definition are accurate and functional to immediately detect any issues post-deployment.

Neglecting these validation steps could risk prolonged service disruption and potential downtime.

@dylanratcliffe dylanratcliffe merged commit db3b28f into main Sep 3, 2024
3 checks passed
@dylanratcliffe dylanratcliffe deleted the new-user branch September 3, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant