Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed to new user #173

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Changed to new user #173

merged 1 commit into from
Sep 3, 2024

Conversation

dylanratcliffe
Copy link
Member

No description provided.

Copy link

github-actions bot commented Sep 3, 2024

mapped Expected Changes

replaced ecs-task-definition › visit-counter-terraform-example
--- current
+++ planned
@@ -1,26 +1,26 @@
-arn: arn:aws:ecs:eu-west-2:540044833068:task-definition/visit-counter-terraform-example:7
-arn_without_revision: arn:aws:ecs:eu-west-2:540044833068:task-definition/visit-counter-terraform-example
-container_definitions: '[{"cpu":256,"environment":[{"name":"FACIAL_RECOGNITION_SERVICE","value":"face-terraform-example.overmind-terraform-example.com"},{"name":"FACIAL_RECOGNITION_SERVICE_USER","value":"visit-counter"}],"essential":true,"healthCheck":{"command":["CMD-SHELL","curl -f http://localhost:80 || exit 1"],"interval":30,"retries":3,"timeout":5},"image":"yeasy/simple-web:latest","memory":512,"mountPoints":[],"name":"visit-counter","portMappings":[{"appProtocol":"http","containerPort":80,"hostPort":80,"protocol":"tcp"}],"systemControls":[],"volumesFrom":[]}]'
+arn: (known after apply)
+arn_without_revision: (known after apply)
+container_definitions: '[{"cpu":256,"environment":[{"name":"FACIAL_RECOGNITION_SERVICE","value":"face-terraform-example.overmind-terraform-example.com"},{"name":"FACIAL_RECOGNITION_SERVICE_USER","value":"facerec"}],"essential":true,"healthCheck":{"command":["CMD-SHELL","curl -f http://localhost:80 || exit 1"],"interval":30,"retries":3,"timeout":5},"image":"yeasy/simple-web:latest","memory":512,"mountPoints":[],"name":"visit-counter","portMappings":[{"appProtocol":"http","containerPort":80}],"volumesFrom":[]}]'
 cpu: "256"
 ephemeral_storage: []
-execution_role_arn: ""
+execution_role_arn: null
 family: visit-counter-terraform-example
-id: visit-counter-terraform-example
+id: (known after apply)
 inference_accelerator: []
-ipc_mode: ""
+ipc_mode: null
 memory: "512"
 network_mode: awsvpc
-pid_mode: ""
+pid_mode: null
 placement_constraints: []
 proxy_configuration: []
 requires_compatibilities:
     - FARGATE
-revision: 7
+revision: (known after apply)
 runtime_platform: []
 skip_destroy: false
-tags: {}
-tags_all: {}
-task_role_arn: ""
+tags: null
+tags_all: (known after apply)
+task_role_arn: null
 terraform_address: module.scenarios[0].aws_ecs_task_definition.visit_counter
 terraform_name: module.scenarios[0].aws_ecs_task_definition.visit_counter
 track_latest: false

unmapped Unmapped Changes

Note

These changes couldn't be mapped to a discoverable cloud resource and therefore won't be included in the blast radius calculation.

updated aws_ecs_service › module.scenarios[0].aws_ecs_service.visit_counter
--- current
+++ planned
@@ -42,7 +42,7 @@
 service_registries: []
 tags: {}
 tags_all: {}
-task_definition: arn:aws:ecs:eu-west-2:540044833068:task-definition/visit-counter-terraform-example:7
+task_definition: (known after apply)
 terraform_address: module.scenarios[0].aws_ecs_service.visit_counter
 terraform_name: module.scenarios[0].aws_ecs_service.visit_counter
 timeouts: null

Blast Radius

items Items edges Edges
1 0

Open in Overmind

warning Risks

high Potential Task Definition and Environment Variable Conflict [High]

The proposed change involves replacing the entire ECS task definition for visit-counter-terraform-example, which includes a change in the environment variable for FACIAL_RECOGNITION_SERVICE_USER from visit-counter to facerec. This could lead to incompatibility or misconfiguration if other elements in the system expect the old environment variable value.

Specific Risks

  • Service Downtime: If the facial recognition service relies heavily on the visit-counter value, there might be failures or unexpected behavior.
  • Configuration Drift: The change in environment variable could lead to discrepancies with related systems or documentation that still reference the old value.

Validation Steps

  1. Check Dependencies: Ensure all services and configurations that interact with FACIAL_RECOGNITION_SERVICE_USER are updated to reflect the new value facerec.
  2. Test Interaction: Validate that the service running under the new task definition with updated environment variables still interacts correctly with the facial recognition service.
  3. Rollback Plan: Prepare a clear rollback strategy in case dependencies on the old value cause unforeseen issues.

Related Resources

  • Current Task Definition: arn:aws:ecs:eu-west-2:540044833068:task-definition/visit-counter-terraform-example:7
  • Proposed Task Definition ID: 540044833068.eu-west-2.ecs-task-definition.visit-counter-terraform-example

medium Potential Issues with Service Scheduling Strategy [Medium]

The task definition update includes a change where the task definition attribute for module.scenarios[0].aws_ecs_service.visit_counter is set to (known after apply), meaning the exact ARN is not predefined. This could introduce issues related to scheduling, resource allocation, or deployment failure.

Specific Risks

  • Deployment Failure: If the ARN is not correctly assigned post-apply, services might fail to launch or correctly bind to the updated task definition.
  • Resource Allocation: Ambiguity in task definition ARN could lead to incorrect resource allocation, causing bottlenecks or underutilization.

Validation Steps

  1. Pre-apply Validation: Manually verify that the ARN to be used post-apply is correctly referenced and is valid.
  2. Post-apply Verification: Ensure the task definition is correctly set in the service after terraform apply, cross-checking with the expected ARN.
  3. Monitor Deployment: Watch the service during deployment to quickly catch and debug any issues related to task definition ARNs.

Related Resources

  • Current Task Definition: arn:aws:ecs:eu-west-2:540044833068:task-definition/visit-counter-terraform-example:7
  • Proposed Service ID: ..

@dylanratcliffe dylanratcliffe merged commit 40ed199 into main Sep 3, 2024
3 checks passed
@dylanratcliffe dylanratcliffe deleted the change-recognition-user branch September 3, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant