ArmoredChat v3 (DomainChat)

[Armored-Dragon]

Major overhaul to the existing chat system.

TODO:

• GIFs, APNGs not animated in new chat #1258
• [ ArmoredChat.js ] Embedded media causes unexpected jitters #1256
• [ ArmoredChat.js ] When starting the application the window sometimes does not scroll to the bottom #1255
• [ ArmoredChat.js ] Loading chat messages from memeory does not preserve the time separation #1253
• Opening location links in new chat #1252
• [ ArmoredChat.js ] Open link in external browser button does not function #1183
• [ ArmoredChat.js ] Add a way to lock or disable external window mode when in VR #1254

LATER: (will be fixed in a future PR)

• Typing indicator #1161

  • Waiting on the resolution of Add support for base64 images in image entity URLs #1278

• [ ArmoredChat.js ] Chat messages should show the message in 3D space near the avatar #1147

  • Waiting on the resolution of Add support for base64 images in image entity URLs #1278

• [ ArmoredChat.js ] Translation support #1148

  • Waiting on the resolution of [ Unified UI ] Settings UI (updated) #1240

• [ ArmoredChat.js ] Embeded videos #1166

  • The current implementation of the chat application is unsatisfactory for embedding videos.

Fixes #1183
Closes #1252
Closes #1253
Fixes #1256
Fixes #1255
Closes #1258
Closes #1254

[ksuprynowicz]

The new chat also seems to forget settings for me on every restart.

[Armored-Dragon]

It would also be really good to have "Copy URL to clipboard" button next to URL - it would be especially useful in VR

I won't be adding any additional features to this pull request, I will absolutely look into adding this feature in a different pull request!

[Armored-Dragon]

The new chat also seems to forget settings for me on every restart.

I can not replicate this issue. Could you provide more information about what is going on? Are there any errors in the logs about JSON parsing failures or anything like that?

[ksuprynowicz]

It also posts this QML error a lot while starting:

[01/15 23:04:04] [WARNING] [default] Qt Quick Layouts: Polish loop detected. Aborting after two iterations.
[01/15 23:04:04] [WARNING] [default] file:///tmp/.mount_OverteBWTqbY/overte/interface/scripts/system/domainChat/qml_widgets/TemplateChatMessage.qml:44:6: QML QQuickText: Binding loop detected for property "width"

[Armored-Dragon]

I have hidden the video embed functionality due to it not working as elegantly as I would like it to. I will reactivate it once I have a more elegant implementation and a dedicated video player widget.

[Armored-Dragon]

I have also added several debugging prints to the code which should hopefully help diagnose the issue @ksuprynowicz was having.

[Armored-Dragon]

There is a wrapping issue currently, I'll have a fix out soonish.