Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix miss makezero bug #6971

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

alingse
Copy link
Contributor

@alingse alingse commented May 26, 2024

  1. Description

I was running github actions to run linter makezero for top github golang repos.

see issues alingse/go-linter-runner#1

and the github actions output https://github.com/alingse/go-linter-runner/actions/runs/9242659719/job/25425759865

====================================================================================================
append to slice `userIds` with non-zero initialized length at https://github.com/ovh/cds/blob/master/engine/api/migrate/migrate_organization.go#L40:13
append to slice `mods` with non-zero initialized length at https://github.com/ovh/cds/blob/master/engine/hooks/trigger_workflow.go#L88:13
====================================================================================================
  1. Related issues
  2. About tests
  3. Mentions

@ovh/cds

Signed-off-by: alingse <alingse@foxmail.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented May 28, 2024

CDS Report build-cds#20626.0 ✘
*

  • Build and Package All -
  • Build and Package Contrib Action ✔
  • Build and Package Contrib Code Plugin ✔
  • Build and Package Contrib Integrations ✔
  • Build and Package Engine, Worker, CLI and Doc ✔
  • Build and Package UI ✔
  • Build Debpacker ✔
  • Build SMTPMock ✔
  • Lint UI Translate ✔
  • Test CLI ✔
  • Test Contrib ✔
  • Test Engine ✘
  • Test SDK ✔
  • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented May 28, 2024

CDS Report build-cds#20626.1 ✔
*

  • Build and Package All -
  • Build and Package Contrib Action ✔
  • Build and Package Contrib Code Plugin ✔
  • Build and Package Contrib Integrations ✔
  • Build and Package Engine, Worker, CLI and Doc ✔
  • Build and Package UI ✔
  • Build Debpacker ✔
  • Build SMTPMock ✔
  • Lint UI Translate ✔
  • Test CLI ✔
  • Test Contrib ✔
  • Test Engine ✔
  • Test SDK ✔
  • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented May 28, 2024

CDS Report integration-cds#20626.1 ✔

  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✔
    • Standalone Tests v1 ✔
    • Standalone Tests v2 ✔

@richardlt richardlt merged commit 389ecf6 into ovh:master May 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants