-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
udn: Wire up multicast for primary networks. #4547
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinqon
force-pushed
the
primary-udn-e2e-multicast
branch
2 times, most recently
from
July 19, 2024 09:53
a58ec67
to
aad2a3c
Compare
tssurya
added
the
feature/user-defined-network-segmentation
All PRs related to User defined network segmentation
label
Jul 19, 2024
qinqon
force-pushed
the
primary-udn-e2e-multicast
branch
from
July 19, 2024 13:07
aad2a3c
to
1b8a8dc
Compare
e2e passes at CI but not locally. |
Default deny is breaking multicast, this are the ACLs so far 2 Default deny ingress/egress ACLs
2 ACLs cluster default allow inter node multicast traffic ingress/egress
2 ACLs per namespace + network for ingress/egress
|
Ok, the per namepsace port group is missing the LSPs
|
qinqon
force-pushed
the
primary-udn-e2e-multicast
branch
2 times, most recently
from
July 23, 2024 12:45
7a8128a
to
12095a4
Compare
Legit unit test failure
|
qinqon
force-pushed
the
primary-udn-e2e-multicast
branch
from
July 23, 2024 15:16
12095a4
to
bf6ec33
Compare
qinqon
changed the title
Primary udn e2e multicast
udn: Wire up multicast for primary networks.
Jul 23, 2024
qinqon
force-pushed
the
primary-udn-e2e-multicast
branch
2 times, most recently
from
July 24, 2024 08:03
62256a9
to
f209a02
Compare
IGMP query test not working for primary UDNs. |
qinqon
force-pushed
the
primary-udn-e2e-multicast
branch
from
July 24, 2024 11:41
f209a02
to
708b0a4
Compare
github-actions
bot
added
area/unit-testing
Issues related to adding/updating unit tests
feature/egress-firewall
All issues related to egress firewall
labels
Jul 24, 2024
qinqon
force-pushed
the
primary-udn-e2e-multicast
branch
3 times, most recently
from
July 26, 2024 07:08
9a141da
to
aada474
Compare
To reuse the multicast UDP and IGMP test at network segmentation test suite this change move the test to a function we can call from there, it also wrap the mechanism to activate at namespace and make both UDP and IGMP take same parameters Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Multicast was disable for UDN, this change activate it only when network segmentation and multicast is enabled and the network is layer2 or layer3. Signed-off-by: Enrique Llorente <ellorent@redhat.com>
At UDN namespace controller was started only if multi net policies was enabled this change activate it also when network segmentation and multicast is enabled. Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
qinqon
force-pushed
the
primary-udn-e2e-multicast
branch
from
August 1, 2024 13:44
aada474
to
75d1d77
Compare
tssurya
added a commit
to tssurya/ovn-kubernetes
that referenced
this pull request
Sep 19, 2024
We kept trying to add the management port for secondary networks into the cluster port group of secondary networks. But that port group doesn't exist yet. It will exist once we get ovn-org#4547 merged but until then this is causing infinite retries from syncMgmtPort erroring out. Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
tssurya
added a commit
to tssurya/ovn-kubernetes
that referenced
this pull request
Sep 19, 2024
We kept trying to add the management port for secondary networks into the cluster port group of secondary networks. But that port group doesn't exist yet. It will exist once we get ovn-org#4547 merged but until then this is causing infinite retries from syncMgmtPort erroring out. Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
tssurya
added a commit
to tssurya/ovn-kubernetes
that referenced
this pull request
Sep 19, 2024
We kept trying to add the management port for secondary networks into the cluster port group of secondary networks. But that port group doesn't exist yet. It will exist once we get ovn-org#4547 merged but until then this is causing infinite retries from syncMgmtPort erroring out. Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
tssurya
added a commit
to tssurya/ovn-kubernetes
that referenced
this pull request
Oct 9, 2024
We kept trying to add the management port for secondary networks into the cluster port group of secondary networks. But that port group doesn't exist yet. It will exist once we get ovn-org#4547 merged but until then this is causing infinite retries from syncMgmtPort erroring out. Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
tssurya
added a commit
to tssurya/ovn-kubernetes
that referenced
this pull request
Oct 9, 2024
We kept trying to add the management port for secondary networks into the cluster port group of secondary networks. But that port group doesn't exist yet. It will exist once we get ovn-org#4547 merged but until then this is causing infinite retries from syncMgmtPort erroring out. Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
zeeke
pushed a commit
to zeeke/ovn-kubernetes-us
that referenced
this pull request
Oct 22, 2024
We kept trying to add the management port for secondary networks into the cluster port group of secondary networks. But that port group doesn't exist yet. It will exist once we get ovn-org#4547 merged but until then this is causing infinite retries from syncMgmtPort erroring out. Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
Closing in favor of #4797 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/e2e-testing
area/unit-testing
Issues related to adding/updating unit tests
feature/egress-firewall
All issues related to egress firewall
feature/user-defined-network-segmentation
All PRs related to User defined network segmentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does and why is it needed
TODO:
pkg/ovn/mutlicast_test.go
Which issue(s) this PR fixes
Fixes #
Special notes for reviewers
How to verify it
Details to documentation updates
Description for the changelog
Does this PR introduce a user-facing change?