-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.0]: Fix several issues for supporting DPUs #4761
Open
EvenChang
wants to merge
13
commits into
ovn-org:release-1.0
Choose a base branch
from
EvenChang:release-1.0-dpu-fixes
base: release-1.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nithyar <nithyar@nvidia.com>
Signed-off-by: nithyar <nithyar@nvidia.com>
Signed-off-by: nithyar <nithyar@nvidia.com>
Signed-off-by: Yun Zhou <yunz@nvidia.com>
Signed-off-by: Yun Zhou <yunz@nvidia.com>
Signed-off-by: Yun Zhou <yunz@nvidia.com>
Signed-off-by: nithyar <nithyar@nvidia.com>
Signed-off-by: nithyar <nithyar@nvidia.com>
Signed-off-by: nithyar <nithyar@nvidia.com>
Signed-off-by: nithyar <nithyar@nvidia.com>
Signed-off-by: nithyar <nithyar@nvidia.com>
EvenChang
requested review from
flavio-fernandes
and removed request for
a team
October 8, 2024 07:06
github-actions
bot
added
the
area/unit-testing
Issues related to adding/updating unit tests
label
Oct 8, 2024
EvenChang
commented
Oct 8, 2024
Comment on lines
143
to
+155
image: | ||
# -- Image repository for ovn-kubernetes components | ||
repository: ghcr.io/ovn-org/ovn-kubernetes/ovn-kube-ubuntu | ||
# -- Specify image tag to run | ||
tag: master | ||
# -- Image pull policy | ||
pullPolicy: IfNotPresent | ||
# -- Image for DPUs | ||
dpuImage: | ||
# -- Image repository for ovn-kubernetes components | ||
repository: ghcr.io/ovn-org/ovn-kubernetes/ovn-kube-ubuntu | ||
# -- Specify image tag to run | ||
tag: master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question.
Do we need to change the tag from master to release-1.0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does and why is it needed
(cherry picked from PR #4634)