[release-1.0]: Fix several issues for supporting DPUs #4761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nithyar <nithyar@nvidia.com>
Signed-off-by: nithyar <nithyar@nvidia.com>
Signed-off-by: nithyar <nithyar@nvidia.com>
Signed-off-by: Yun Zhou <yunz@nvidia.com>
Signed-off-by: Yun Zhou <yunz@nvidia.com>
Signed-off-by: Yun Zhou <yunz@nvidia.com>
Signed-off-by: nithyar <nithyar@nvidia.com>
Signed-off-by: nithyar <nithyar@nvidia.com>
Signed-off-by: nithyar <nithyar@nvidia.com>
Signed-off-by: nithyar <nithyar@nvidia.com>
Signed-off-by: nithyar <nithyar@nvidia.com>
EvenChang
requested review from
flavio-fernandes
and removed request for
a team
github-actions
bot
added
the
area/unit-testing
EvenChang
commented
Oct 8, 2024
Comment on lines
143
to
+155
| image: | ||
| # -- Image repository for ovn-kubernetes components | ||
| repository: ghcr.io/ovn-org/ovn-kubernetes/ovn-kube-ubuntu | ||
| # -- Specify image tag to run | ||
| tag: master | ||
| # -- Image pull policy | ||
| pullPolicy: IfNotPresent | ||
| # -- Image for DPUs | ||
| dpuImage: | ||
| # -- Image repository for ovn-kubernetes components | ||
| repository: ghcr.io/ovn-org/ovn-kubernetes/ovn-kube-ubuntu | ||
| # -- Specify image tag to run | ||
| tag: master |
There was a problem hiding this comment.
I have a question.
Do we need to change the tag from master to release-1.0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does and why is it needed
(cherry picked from PR #4634)