shared portgroup support #4772
Open
shared portgroup support #4772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/unit-testing
cathy-zhou
force-pushed
the
wip_shared_portgroup
branch
7 times, most recently
from
7e332b8
to
5e29b48
Compare
port groups can be shared by network policies that share the same local pod selector. Signed-off-by: Yun Zhou <yunz@nvidia.com>
fix network policy test cases to make use of pod selector port groups. Signed-off-by: Yun Zhou <yunz@nvidia.com>
cathy-zhou
force-pushed
the
wip_shared_portgroup
branch
from
5e29b48
to
152eb52
Compare
|
@npinaeva please take a look for upgrade (specifically, the deletion of stale network policy based port gorup), I am current delete those during the next reboot. I can also change it to delete it after the new shared port group is created for the specific network policy, but that will be done each time during restart even when the upgrade is already done. Let me know if you have any preference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does and why is it needed
Which issue(s) this PR fixes
Fixes #
Special notes for reviewers
How to verify it
Details to documentation updates
Description for the changelog
Does this PR introduce a user-facing change?