Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abproute: Do not fail when a pod has bad gw config #4793

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zeeke
Copy link
Contributor

@zeeke zeeke commented Oct 22, 2024

Setting the k8s.ovn.org/routing-network pod annotation to an empty string on a pod that is not host-networked is the wrong configuration, and it has no effect on the OVN configuration. However, if an ovnkube-node pod is restarted, it is not able to go up and running as the above mentioned configuration triggers an error.

Make the abprout.Repair() procedure resilient to bad user configuration, in order to improved the stability of the cluster.

What this PR does and why is it needed

Setting the k8s.ovn.org/routing-network pod annotation to an empty string on a pod that is not host-networked is the wrong configuration, and it has no effect on the OVN configuration. However, if an ovnkube-node pod is restarted, it is not able to go up and running as the above mentioned configuration triggers an error.

Make the abprout.Repair() procedure resilient to bad user configuration, in order to improved the stability of the cluster.

Which issue(s) this PR fixes

Fixes #
https://issues.redhat.com/browse/OCPBUGS-37685

Special notes for reviewers

I'm not sure if there is a cleaner way to unit test this case. @jordigilh can you please review?

How to verify it

Steps to reproduce the problem are listed here
https://gist.github.com/zeeke/378842c9b64f02895ce0175172238c0c

Details to documentation updates

Description for the changelog

Does this PR introduce a user-facing change?


@zeeke zeeke requested a review from a team as a code owner October 22, 2024 10:55
@github-actions github-actions bot added area/unit-testing Issues related to adding/updating unit tests feature/egress-gateway All issues related to ICNI/APBR labels Oct 22, 2024
Setting the `k8s.ovn.org/routing-network` pod annotation to an empty string
on a pod that is not host-networked is a wrong configuration, and it has
no effect on the OVN configuration. However, if an ovnkube-node pod is
restarted, it is not able to go up and running as the above mentioned
configuration triggers an error.

Make the `abprout.Repair()` procedure resilient to bad user
configuration, in order to improved the stability of the cluster.

Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/unit-testing Issues related to adding/updating unit tests feature/egress-gateway All issues related to ICNI/APBR
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant