Add support for multicast in user defined networks. #4797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dceara
added
the
feature/user-defined-network-segmentation
dceara
force-pushed
the
udn-multicast
branch
3 times, most recently
from
5c850fe
to
0c53761
Compare
github-actions
bot
added
the
area/unit-testing
dceara
force-pushed
the
udn-multicast
branch
4 times, most recently
from
7d7735d
to
4902a06
Compare
Otherwise with UDN we risk trying to capture IGMP queries on the wrong interface. Signed-off-by: Dumitru Ceara <dceara@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
…oups. We expect the management port to always be part of the per-network cluster port group. Signed-off-by: Dumitru Ceara <dceara@redhat.com>
Do this only if the network segmentation feature is enabled. Signed-off-by: Dumitru Ceara <dceara@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
… port group. Now that the cluster port group actually exists, add the mgmt port to it (similar to what happens on the default network). Signed-off-by: Dumitru Ceara <dceara@redhat.com>
This was originally skipped because there was no per-UDN cluster-port-group. Signed-off-by: Dumitru Ceara <dceara@redhat.com>
To reuse the multicast UDP and IGMP test at network segmentation test suite this change move the test to a function we can call from there, it also wrap the mechanism to activate at namespace and make both UDP and IGMP take same parameters Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Multicast was disable for UDN, this change activate it only when network segmentation and multicast is enabled and the network is layer2 or layer3. Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com>
Signed-off-by: Enrique Llorente <ellorent@redhat.com> Co-authored-by: Dumitru Ceara <dceara@redhat.com> Signed-off-by: Dumitru Ceara <dceara@redhat.com>
The tests will now run for both default network and primary UDN networks. Signed-off-by: Enrique Llorente <ellorent@redhat.com> Co-authored-by: Dumitru Ceara <dceara@redhat.com> Signed-off-by: Dumitru Ceara <dceara@redhat.com>
dceara
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does and why is it needed
This adds:
Which issue(s) this PR fixes
Special notes for reviewers
Cluster-wide port group management routines have been moved to the base network controller and now are used by secondary network controllers too.
Multicast ACL management routines have been moved to the base network controller and now are used by secondary network controllers too.
E2e and unit tests have been adapted to run for both default and primary UDN networks for the features mentioned above.
How to verify it
Unit and end to end tests have been adapted/created.
Details to documentation updates
Description for the changelog
Does this PR introduce a user-facing change?