-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement binding strategy in creating and binding lport #111
base: master
Are you sure you want to change the base?
Conversation
Address #95 |
Overview | ||
======== | ||
|
||
In OVN, a logical port can be bind to a local OVS port on any chassis/hypervisor, depending on the VM scheduler (e.g., ``nova-scheduler``). The binding strategy potentially impacts the network performance. That is binding all logical ports in a logical network on a single hypervisor performs differently than distributing the ports on multiple hypervisors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to linewrap this file at 80 characters. Can you do that please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mestery sorry about the wrong format. Please review the updated PR.
- see the guide: ansible/doc/binding-strategy.rst Signed-off-by: Hui Kang <kangh@us.ibm.com>
aaf7a49
to
703f276
Compare
class LogicalNetwork(): | ||
def __init__(self): | ||
self.sandboxes = [] | ||
self.ports_per_network = 0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to add 'self.lswitch = None' in init(), otherwise get_lswitch() before set_lswitch() may raise a exception
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got you. Thanks.
For distribute lswithes/ports to sandbox evenly, I run rally-ovs multiple times, each time with a set of sandbox, like: |
@l8huang your understanding is correct. The new variable |
I will combine the commits into one when the PR is ready for merge. Thanks. |
@l8huang Just a gentle reminder: do you mind spending some minutes reviewing this PR? Thanks. |
Signed-off-by: Hui Kang kangh@us.ibm.com