Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow/fetch problems + fixes #2

Open
foosint opened this issue Mar 8, 2023 · 1 comment
Open

workflow/fetch problems + fixes #2

foosint opened this issue Mar 8, 2023 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@foosint
Copy link

foosint commented Mar 8, 2023

At the moment the automatic workflow does not work and aborts with a permission error.

To fix this, the workflow would need other permissions:

# permissions
permissions:
  contents: write
  packages: write

Since scheduled workflow runs are not guaranteed to run at the exact set time and may even abort completely, I would suggest slightly modifying the fetch part.

Set the workflow cron to hourly, but make the following changes in the fetch script itself:

  1. filename only with date without time.
  2. wget downloads only if the file does not already exist. (-nc or -N option - which is better?)

This guarantees that the download for a day only takes place 1x and by the hourly workflow schedule is pretty much guaranteed that fetch should run at least once a day.

@foosint foosint added bug Something isn't working enhancement New feature or request labels Mar 8, 2023
@fdov21
Copy link
Contributor

fdov21 commented Mar 9, 2023

I updated the permissions now. Your solutions sound nice though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants