-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the depreciated Antora family resource identifier with the actual valid once #4128
Comments
I did some intense 🥵 tests with following results:
The bad news is, that pdf generation does not work when exchanging the family coordinates from depreciated to new 💣 🔥 This is because the family name cant be resolved like we did with attributes. I have filed an issue in Zulip, see: https://antora.zulipchat.com/#narrow/stream/282400-users/topic/Antora.20family.20coordinates.20.E2.80.93.20asciidoctor-pdf Summary, we can prepare having the correct family directory structure including the location of the nav.adoc file, but have to wait using the family resource identifiers until the pdf generation is fixed. @michl19 fyi too |
This is precisely why I have advised against using Asciidoctor PDF the way this project is using it, outside of the Antora build. Asciidoctor PDF by itself is not aware of Antora's structure or references and, as a result, you're inevitably going to run into problems doing it this way. And you should not try to modify your content to cater to Asciidoctor PDF. The right way to do it is to allow Antora to invoke Asciidoctor PDF with documents it has prepared. And that's precisely the extension the Antora project is currently working on creating (which got slightly held up by the Antora 3 release). I have provided more details in the chat. |
WHAT Needs to be Documented?
Based on a discussion with @movavelinux (Antora) at https://antora.zulipchat.com, we use depreciated family resource identifiers. This should be fixed, the proper family identifyer can be found at: https://docs.antora.org/antora/2.3/page/resource-id/#id-coordinates
{partialsdir}
-->partial$
{examplesdir}
-->example$
Note that
{attachmentsdir}
has to be kept for the time being.From @mojavelinux
{modulesdir}/pages/_partials/nav.adoc
We also have to rename the
_partials
directory and relocate it:https://docs.antora.org/antora/2.3/family-directories/
WHERE Does This Need To Be Documented (Link)?
We have to do a search and replace in all modules, in all repos. A PR will be created there too and referenced.
WHY Should This Change Be Made?
Depreciated/legacy family identifyers will most likely get removed with Antora 3
(Optional) What Type Of Content Change Is This?
(Optional) Which Manual Does This Relate To?
@EParzefall fyi
The text was updated successfully, but these errors were encountered: