Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release files_mediaviewer 1.0.5 #401

Closed
32 of 44 tasks
phil-davis opened this issue Apr 8, 2021 · 14 comments
Closed
32 of 44 tasks

Release files_mediaviewer 1.0.5 #401

phil-davis opened this issue Apr 8, 2021 · 14 comments
Milestone

Comments

@phil-davis
Copy link
Contributor

phil-davis commented Apr 8, 2021

PR #400 "[Security] Bump y18n from 4.0.0 to 4.0.3"
PR #407 "[Security] Bump ssri from 6.0.1 to 6.0.2"
PR #532 "Bump kind-of from 6.0.2 to 6.0.3"
PR #542 "Bump webpack-cli from 4.8.0 to 4.9.1"
PR #546 "Bump style-loader from 3.2.1 to 3.3.1"
PR #551 "Bump sass from 1.38.2 to 1.43.4"
PR #552 "Bump css-loader from 6.2.0 to 6.5.0"
PR #553 "Bump swiper from 7.0.2 to 7.2.0"
PR #554 "Bump webpack from 5.51.1 to 5.61.0"
PR #555 "Bump svelte from 3.42.4 to 3.44.1"
PR #556 "Bump @babel/preset-env from 7.15.0 to 7.16.0"
PR #557 "Bump @babel/core from 7.15.0 to 7.16.0"
PR #548 "[l10n] translations make, extract wrong texts for js files"
PR #558 "Fix l10n processing"

Product approval

  • Verify transifex commits are in master: If a folder https://github.com/owncloud//tree/master/l10n exists, then https://drone.owncloud.com/owncloud/ should receive nightly '[tx] updated from transifex` ...
  • Ping pmaier to check info.xml description and screenshot
  • Get approval on translations from pmaier - send the date of the last tx commit from drone to Patrick

QA

  • Create QA Milestone and set the description to $version
  • Move tickets from milestone development to qa (testplan and tickets mentioned in release ticket)
  • Create release branch with the format "release-$version"
  • Create "$version Testplan" -> [QA] 1.0.5 Testplan #533
  • copy new/reopened issues from the previous release ticket as 'Issues to review' below.
  • check if Non-normal Release Process applies, and adapt this checklist.

Documentation

  • Changes in the docs needed? If so create issue in owncloud/docs.

Marketing

Build

All actions to be done on the release branch from here:

  • Bump version in info.xml (no version suffix)
  • Bump "sonar.projectVersion=" in sonar-project.properties (no version suffix)
  • Check php version dependency in info.xml
  • Check minimum ownCloud version dependency in info.xml
  • Change CHANGELOG.md 'Unreleased' to '$version' (today's date)

Beta/RC

  • Ping product owner to create github tag for v${version}-rc1 on release branch (see https://confluence.owncloud.com/display/EN/Product+Owners+List)
  • Build and sign RC tarball from github tag v${version}-rc1 (see handbook for how to build)
  • Upload as Github release using changelog entries
  • Test and document in testplan + manual explorative testing:
    • If this is an enterprise app: Enabling the app must start the grace period
    • If this is the initial release of an app: Check that the minimum version constraint resolves correctly
    • Add section "Changlog Testing" using github releases text or CHANGELOG.md from release branch
    • Do changelog tests
    • Do regression tests
    • smoke test with docker image owncloud/server:latest
    • => Final "Go" from QA (set 'QA-ready' label) => else do another RC after fixing issues in the "release-$version" branch

Final

  • Check that no documentation issues are pending
  • Rename last RC tarball to final
  • Create github tag for final v${version} on release branch
  • Upload as Github release using changelog entries

Publishing

  • Upload tarball to marketplace (see handbook in confluence for details)
  • Publish tarball for customers - old 10, old 10.0 and new portal (see handbook for details)
  • Send mail to release-coordination with link to this ticket and to the changelog
  • Copy email to rocket chat #updates channel

Post-release

@mmattel
Copy link
Contributor

mmattel commented Apr 17, 2021

Another Security Bump #407

@jnweiger jnweiger changed the title Release 1.0.5 Release files_mediaviewer 1.0.5 Apr 21, 2021
@jnweiger
Copy link
Contributor

jnweiger commented Jul 22, 2021

@phil-davis

  • We have a transifex commit coming in here really every day. Its this sane?
  • There are 21 library bumps waiting. Do we want to merge them? Looks straight forward to me.

@phil-davis
Copy link
Contributor Author

Transifex is pushing a commit every day that only updates the POT-Creation-Date
2813808

That is not sane. It does not happen in other repos. I am not familiar with the Transifex setups - there must be a setting "somewhere on the internet" to stop that happening.

Library bumps: they are JavaScript things. Maybe some JS developer could look and see if there is anything that obviously should not be done. Then we merge everything and manually check the app.

@jnweiger
Copy link
Contributor

jnweiger commented Aug 4, 2021

@pmaier1 @micbar who owns files_mediaviewer?

@micbar
Copy link
Contributor

micbar commented Aug 12, 2021

It was created by Florian Lenz. Currently no active maintainer. Needs to be handled by server team

@jnweiger
Copy link
Contributor

@janackermann Please push the prerelase library bumps, then move to RC-needed.

@AlexAndBear
Copy link

AlexAndBear commented Oct 28, 2021

(+ Transifex translation 'Open in Media Viewer' de,es,fr,ar)

@AlexAndBear AlexAndBear removed their assignment Nov 2, 2021
@AlexAndBear
Copy link

Done

@jnweiger
Copy link
Contributor

jnweiger commented Nov 9, 2021

@janackermann files_mediaviewer does not have sonar-project.properties
Please add that file to my release-1.0.5 branch if needed? Will be merged to master after the release.

@jnweiger jnweiger modified the milestones: QA, development Nov 9, 2021
@jnweiger
Copy link
Contributor

jnweiger commented Nov 9, 2021

Remaining QA issues from 1.0.4

New issues found while testing 1.0.5

  • ...

@AlexAndBear
Copy link

Not fixed, reopening Text and icon in file actions menu is missing #337 - Text and icon in file actions menu is missing

Texts should be there at least?!

@jnweiger
Copy link
Contributor

Not fixed, reopening Text and icon in file actions menu is missing #337 - Text and icon in file actions menu is missing

Texts should be there at least?!

Yep. Texts and icons are there. But english texts only. Reopening #337 again, back in dev.

@jnweiger
Copy link
Contributor

Back in dev, I believe #337 (comment) needs a fix.

@GeraldLeikam
Copy link
Contributor

close after release

@tbsbdr tbsbdr unpinned this issue Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants