Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exif description to the slideshow #525

Closed
oparoz opened this issue Feb 17, 2016 · 9 comments
Closed

Add exif description to the slideshow #525

oparoz opened this issue Feb 17, 2016 · 9 comments

Comments

@oparoz
Copy link
Contributor

oparoz commented Feb 17, 2016

@0xb0ba has opened a PR which adds the EXIF description to an image shown in the slideshow, if it exists. There are still quite a few opened questions regarding the design.

Should the description :

  • Be centred?
  • Be spread over 3 lines?
  • Include a scroller or rollover? Rollover would fill the screen with that description since we have to keep it narrow. A scroller requires 2 additional touch areas instead of an ugly scrollbar
  • Be enabled/disabled via a button? Because it can mask the view and would not disappear when interacting with the slideshow, so, the default would be to hide the description
  • Be shown in a sliding sidebar?

Examples

Picasa

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@oparoz oparoz changed the title Add exif description to slideshow Add exif description to the slideshow Feb 17, 2016
@0xb0ba
Copy link
Contributor

0xb0ba commented Feb 26, 2016

Be centred?

yes

Include a scroller or rollover?

nothing

Be enabled/disabled via a button?

no. autohide in 3 sec

Be shown in a sliding sidebar?

yes. all tags (all photo tags) from exif. but php exif lib is poor. exiftool?

@Bugsbane
Copy link

Be centered?

Yes

Spread over 3 lines?

Personally I would make a div with a minimum height of around 1em (ie a single line high) and a max height of a few percentage points of the screen height (I'd need to judge this visually on my desktop, and I'm on my phone now, but I can do a mock-up for precise numbers), center it horizontally and align it to the bottom of the screen with a margin of say .5 em.

I'd make the text color white with a black css dropdown shadow (this tends towards decent readability against a wide variety of backgrounds as long as the shadow outlines the text at least a little in all directions, maybe blur 3px, with no x offset and a y offset of 2px).

I'd set overflow to cut off, ideally with an opacity gradient fading the text out at the end, and an ellipses to signify more text being available, but have a tooltip display with a system standard font size with the full text on hover or click.

As Jan suggests, I'd go with fading after 3 seconds, but I'd reverse the fade-out if the text is hovered over or clicked on. Onmouseout restart the 3 second countdown.

No to buttons, scrollers, roll overs and scroll bars.

Yes to showing in the sidebar.

@oparoz
Copy link
Contributor Author

oparoz commented Feb 28, 2016

Thanks for the feedback. It's interesting that both of you think the description should fade away with the rest. I can think of at least one use-case where I would want the description to show permanently: In slideshow mode in a real gallery if I wanted to add a caption to each image. So maybe there should be 2 modes, one with tooltip + fade and a permanent description one

I'd greatly appreciate some mockups.

Things to look for:

  • There should be a max width to keep the description readable. A paragraph is better than a long line
  • Both the filename and the description have to be shown
  • Some mockups should include the other buttons in the UI to be able to see how it all fits together

@0xb0ba
Copy link
Contributor

0xb0ba commented Feb 28, 2016

serious doubts that the file name should be in full screen.

@Bugsbane
Copy link

Yes, I agree on the max-width.

I question whether it's best to show both the description and the filename at
all time, especially in slideshow mode. Generally, if an actual description
has been given then it's more meaningful to the user in a slideshow mode
(which is more about casual viewing than hunting down technical details).
Personally I would suggest showing the description where one has been set, the
filename where one has not, and making the filename available in the sidebar
info for anyone looking for more than is shown in the sileshow view.

@Bugsbane
Copy link

Bugsbane commented Feb 28, 2016

I'm happy to run up a mockup though as soon as we have a general agreement on
what should be in it, or at least that people have polarised around a couple
of options.

Yes, I agree on the max-width.

I question whether it's best to show both the description and the filename
at all time, especially in slideshow mode. Generally, if an actual description
has been given then it's more meaningful to the user in a slideshow mode
(which is more about casual viewing than hunting down technical details).
Personally I would suggest showing the description where one has been set, the
filename where one has not, and making the filename available in the sidebar
info for anyone looking for more than is shown in the sileshow view.

@oparoz
Copy link
Contributor Author

oparoz commented Feb 28, 2016

I'm happy to run up a mockup though as soon as we have a general agreement on
what should be in it, or at least that people have polarised around a couple
of options.

Makes sense

@turb
Copy link

turb commented May 24, 2016

Hello, what options still need to be agreed on, in order to merge this PR?

If the only one is "should both description and filename be displayed, or only the description", my own preference goes to only the description (filename makes little sense when the description has been filled).

@oparoz
Copy link
Contributor Author

oparoz commented Sep 4, 2016

This issue was moved to nextcloud/gallery#114

@oparoz oparoz closed this as completed Sep 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants