-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exif description to the slideshow #525
Comments
yes
nothing
no. autohide in 3 sec
yes. all tags (all photo tags) from exif. but php exif lib is poor. exiftool? |
Yes
Personally I would make a div with a minimum height of around 1em (ie a single line high) and a max height of a few percentage points of the screen height (I'd need to judge this visually on my desktop, and I'm on my phone now, but I can do a mock-up for precise numbers), center it horizontally and align it to the bottom of the screen with a margin of say .5 em. I'd make the text color white with a black css dropdown shadow (this tends towards decent readability against a wide variety of backgrounds as long as the shadow outlines the text at least a little in all directions, maybe blur 3px, with no x offset and a y offset of 2px). I'd set overflow to cut off, ideally with an opacity gradient fading the text out at the end, and an ellipses to signify more text being available, but have a tooltip display with a system standard font size with the full text on hover or click. As Jan suggests, I'd go with fading after 3 seconds, but I'd reverse the fade-out if the text is hovered over or clicked on. Onmouseout restart the 3 second countdown. No to buttons, scrollers, roll overs and scroll bars. Yes to showing in the sidebar. |
Thanks for the feedback. It's interesting that both of you think the description should fade away with the rest. I can think of at least one use-case where I would want the description to show permanently: In slideshow mode in a real gallery if I wanted to add a caption to each image. So maybe there should be 2 modes, one with tooltip + fade and a permanent description one I'd greatly appreciate some mockups. Things to look for:
|
serious doubts that the file name should be in full screen. |
Yes, I agree on the max-width. I question whether it's best to show both the description and the filename at |
I'm happy to run up a mockup though as soon as we have a general agreement on Yes, I agree on the max-width.
|
Makes sense |
Hello, what options still need to be agreed on, in order to merge this PR? If the only one is "should both description and filename be displayed, or only the description", my own preference goes to only the description (filename makes little sense when the description has been filled). |
This issue was moved to nextcloud/gallery#114 |
@0xb0ba has opened a PR which adds the EXIF description to an image shown in the slideshow, if it exists. There are still quite a few opened questions regarding the design.
Should the description :
Examples
Picasa
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: