Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If there is no browser history, exit the slideshow by calling stop. #468

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

If there is no browser history, exit the slideshow by calling stop. #468

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ee22c3
If there is no browser history, exit the slideshow by calling stop.
setnes Nov 8, 2015
f058ad1
Merge remote-tracking branch 'upstream/master' into no-history-stop
setnes Dec 7, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions js/slideshowcontrols.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,11 +350,11 @@
_exit: function () {

// Only modern browsers can manipulate history
if (history && history.replaceState) {
if (history && history.replaceState && window.history.length > 1) {
// We simulate a click on the back button in order to be consistent
window.history.back();
} else {
// For ancient browsers supported in core
// There is no history to go back to.
this.stop();
}
},
Expand Down