[milestone/12.0.3] Milestone 12.0.3 (#1236)

* - CreateDocumentAction: make availability dependant on OCAppProvider.supportsCreateDocument - AccountConnection: create Open with actions dependant on OCAppProvider.supportsCreateDocument - OpenInWebAppAction: - introduce new "auto" mode that uses the best available method - or shows an error - limit size of icons to a maximum of 32x32 points - update SDK for new feature detection capabilities * - add support for TUS upload mtime metadata header (fixing #1227) * - FileProviderExtension: add additional debug output for enumerator * FileProvider: - add missing errorHandler calls to FileProviderContentEnumerator - add last resort enumeration completion call to FileProviderEnumeratorObserver.dealloc - add additional debug logging * - FIleProviderContentEnumerator: add/refine more debug logging * - bump version to 12.0.3 and build number to 271 * removed the logo label from the sidebar navigation bar to have more space for the logo image * - update SDK to fix owncloud/enterprise#5811 * - fix #1254 * Example JSON + README (#1255) Co-authored-by: Michael Stingl <git@michaelstingl.com> * Cleanup of Theming folder (#1260) * Remove old PLIST examples * move ownCloud.online theme + assets * move EMM assets * Adjust Fastfile for moved themes + assets * updated to Xcode 14.3 * move all app resources to the correct place in one copy command * updated to 14.3.1 --------- Co-authored-by: Michael Stingl <git@michaelstingl.com> Co-authored-by: Matthias Hühne <github@hosy.de> * - FileProvider: fix enumerator queue completion slowdown/blocking * - show vendor label in the sidebar if app is unbranded - added accessibility label to the logo image * - FileProvider cleanup and additional debug logging * - BottomButtonBar: avoid collapse of selectButton (fixes owncloud/enterprise#5889) * - add background image to welcome screen - add support for RGBA hex values to CSS * - change welcome screen background default color from dark to bright * - BookmarkViewController: add .bookmarkEditor CSS selector * - ThemeCSS: add support for $cssSelector.cssProperty * Assets.xcassets/AppIcon.appiconset generated with fastlane + welcome screen background (#1264) * - add background image to welcome screen - add support for RGBA hex values to CSS * Assets.xcassets/AppIcon.appiconset generated with fastlane * align icon name with branding --------- Co-authored-by: Felix Schwarz <fs-git@iospirit.com> Co-authored-by: Michael Stingl <git@michaelstingl.com> * - change welcome screen background default color from dark to bright * Assets.xcassets/AppIcon.appiconset generated with fastlane * rename vanilla appiconset again for fastlane changes * - ThemeCSS+SystemColors: add convenience methods to easily add CSS records for colors, incl. a set of system colors - ThemeCollection: add system colors (f.ex. UIColor.systemBlue as `os.color.blue`) and theme base colors (as `theme.color.light` and `theme.color.dark`) to CSS object * Vanilla: change welcome screen background default color from bright to dark * - BookmarkViewController: - add permanent logo branding to top of the view - make branding elements use same CSS selectors as welcome screen - ComposedMessageView: make CSS selectors extension public - RoundCornerBackgroundView: add new .fillImage property that allows filling the view with an image with "scaleAspectFill" contentMode * - BookmarkViewController: remove table view background image from branded builds * - RoundCornerBackgroundView: fix bug in sizeThatFills() * - DisplayViewController: handle nil OCQueryChangeSet.queryResult (should fix crash reported in #1245 (comment)) * fixed missing translation strings or localized function * fixed bug in sidebar: label color got the same color as background color and label was not readable, if lightBrandColor was similar to #000000 * - FileProviderExtension: add safeguards around `[NSError fileProviderErrorForNonExistentItemWithIdentifier:]` for the case that iOS (illegally) passes in a nil `identifier`, leading to a crash in said NSError method * [fix/overlapping-sharing-buttons] Overlapping Sharing Buttons (#1248) * [fix/passcode-device-enforced] MDM Parameter - Enforce Passcode Setup (#1249) * [fix/sidebar-logo] Sidebar Logo (#1247) * [translation-sync] Translation sync (#1250) * - minimal change to reopen PR * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * - revert minimum change to THIRD_PARTY.txt * [tx] updated from transifex * - fixed UTF issues - fixed missing german translations --------- Co-authored-by: Felix Schwarz <fs-git@iospirit.com> Co-authored-by: ownClouders <devops@owncloud.com> * - update SDK * - update SDK to update error message for OCErrorAuthorizationNoMethodData * - add "An error occurred" to Localizable.strings * - SDK update with updated strings * GH workflows: - add LocalizationTests with automatic UTF-16 to UTF-8 conversion * - GitHub workflows: move new GH workflow out of workflows folder to avoid permission issue - fix non-empty Branding.plist * Translation sync (#1269) * - minimal change to reopen PR * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * - revert minimum change to THIRD_PARTY.txt * [tx] updated from transifex * - fixed UTF issues - fixed missing german translations * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * - fix file encoding for en-GB.lproj/Localizable.strings --------- Co-authored-by: Matthias Hühne <github@hosy.de> Co-authored-by: ownClouders <devops@owncloud.com> * - update ios-sdk to gain ocstringstool - remove LocalizationTests.swift - remove UTF-8/16 enforcements for .strings files from ownCloud.xcodeproj - add tools/normalizestrings based on ios-sdk/ocstringstool - update GH action (now normalize-strings.yml) - normalize strings files to UTF-8 * - update release notes for 12.0.3 * - NSObject+ThemeApplication: fix wrong label colors for ThemeCSSLabels that are also subject to NSObject.applyThemeCollection() calls * - AppRootViewController + InitialSetupViewController: move initial setup view into own view controller - InitialSetupViewController: implement status bar style support for consistent status bar colors also pre-iOS 17 * - fix iOS 17 initial setup color issue * - address owncloud/core#40953 (comment) via SDK update * - fix: rename of a bookmark is not always reflected in the account list * - BottomButtonBar: adapt layout dynamically to size class, placing the promptText above the buttons in any but regular horizontal class size and stretching the buttons to fill the space beneath it * - ClientSidebarViewController: properly initialize accountsControllerSectionSource with item version tracking * - fix SwiftLint warnings * added missing Calens changelog files * added latest app store release notes * Calens changelog updated --------- Co-authored-by: Matthias Hühne <github@hosy.de> Co-authored-by: Michael Stingl <214010+michaelstingl@users.noreply.github.com> Co-authored-by: Michael Stingl <git@michaelstingl.com> Co-authored-by: Matthias Hühne <mhuehne@owncloud.com> Co-authored-by: ownClouders <devops@owncloud.com> Co-authored-by: hosy <hosy@users.noreply.github.com>
owncloud · Sep 5, 2023 · 1107434 · 1107434
1 parent 51386bf
commit 1107434
Show file tree

Hide file tree

Showing 191 changed files with 3,742 additions and 1,545 deletions.
diff --git a/.github/normalize-strings.yml b/.github/normalize-strings.yml
@@ -0,0 +1,28 @@
+name: Normalize .strings file encoding
+# This workflow is triggered on pushes to the repository.
+on:
+  push:
+    branches:
+    - fix/*
+    - feature/*
+    - milestone/*
+    - translation-sync
+
+jobs:
+  build:
+    runs-on: macos-latest
+    name: Normalize .strings file encoding
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodules: true
+      - name: Xcode version
+        run: /usr/bin/xcodebuild -version
+      - name: Normalize .strings files to UTF-8
+        run: ./normalizestrings.sh
+        working-directory: ./tools/normalizestrings/
+      - name: Commit files
+        uses: stefanzweifel/git-auto-commit-action@v4
+        with:
+          commit_message: Normalized Localizable.strings encoding (UTF-8)
+          file_pattern: '*.strings'
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,73 @@
+Changelog for ownCloud iOS Client [12.0.3] (2023-08-31)
+=======================================
+The following sections list the changes in ownCloud iOS Client 12.0.3 relevant to
+ownCloud admins and users.
+
+[12.0.3]: https://github.com/owncloud/ios-app/compare/milestone/12.0.2...milestone/12.0.3
+
+Summary
+-------
+
+* Bugfix - Upload-Metadata: [#1227](https://github.com/owncloud/ios-app/issues/1227)
+* Bugfix - Open Folder in Files.app: [#1240](https://github.com/owncloud/ios-app/issues/1240)
+* Bugfix - Connection name: [#1254](https://github.com/owncloud/ios-app/issues/1254)
+* Bugfix - Unable to access files from Files.app: [#1262](https://github.com/owncloud/ios-app/issues/1262)
+* Bugfix - File Provider Crash: [#1266](https://github.com/owncloud/ios-app/issues/1266)
+* Bugfix - Translation: [#1269](https://github.com/owncloud/ios-app/pull/1269)
+* Bugfix - Open in Web for ownCloud 10: [#5747](https://github.com/owncloud/enterprise/issues/5747)
+* Bugfix - Copy Item not working: [#5889](https://github.com/owncloud/enterprise/issues/5889)
+
+Details
+-------
+
+* Bugfix - Upload-Metadata: [#1227](https://github.com/owncloud/ios-app/issues/1227)
+
+   TUS -H Upload-Metadata: mtime missing
+
+   https://github.com/owncloud/ios-app/issues/1227
+
+* Bugfix - Open Folder in Files.app: [#1240](https://github.com/owncloud/ios-app/issues/1240)
+
+   In some cases it was not possible to open Folder using iOS Files.app.
+
+   https://github.com/owncloud/ios-app/issues/1240
+
+* Bugfix - Connection name: [#1254](https://github.com/owncloud/ios-app/issues/1254)
+
+   Connection name doesn't change immediately
+
+   https://github.com/owncloud/ios-app/issues/1254
+
+* Bugfix - Unable to access files from Files.app: [#1262](https://github.com/owncloud/ios-app/issues/1262)
+
+   In some cases it was not possible to access files from the Files.app.
+
+   https://github.com/owncloud/ios-app/issues/1262
+
+* Bugfix - File Provider Crash: [#1266](https://github.com/owncloud/ios-app/issues/1266)
+
+   IOS invokes a FileProvider method with a nil value, which causes a crash.
+
+   https://github.com/owncloud/ios-app/issues/1266
+
+* Bugfix - Translation: [#1269](https://github.com/owncloud/ios-app/pull/1269)
+
+   Updated translations from Transifex.
+
+   https://github.com/owncloud/ios-app/pull/1269
+
+* Bugfix - Open in Web for ownCloud 10: [#5747](https://github.com/owncloud/enterprise/issues/5747)
+
+   Open in Web feature was not available for ownCloud 10 instances in the app.
+
+   https://github.com/owncloud/enterprise/issues/5747
+
+* Bugfix - Copy Item not working: [#5889](https://github.com/owncloud/enterprise/issues/5889)
+
+   Copy and paste to a Space was not working
+
+   https://github.com/owncloud/enterprise/issues/5889
+
 Changelog for ownCloud iOS Client [12.0.2] (2023-06-23)
 =======================================
 The following sections list the changes in ownCloud iOS Client 12.0.2 relevant to

diff --git a/changelog/12.0.3_2023-08-31/1227 b/changelog/12.0.3_2023-08-31/1227
@@ -0,0 +1,5 @@
+Bugfix: Upload-Metadata
+
+TUS -H Upload-Metadata: mtime missing
+
+https://github.com/owncloud/ios-app/issues/1227
diff --git a/changelog/12.0.3_2023-08-31/1240 b/changelog/12.0.3_2023-08-31/1240
@@ -0,0 +1,5 @@
+Bugfix: Open Folder in Files.app
+
+In some cases it was not possible to open Folder using iOS Files.app.
+
+https://github.com/owncloud/ios-app/issues/1240
diff --git a/changelog/12.0.3_2023-08-31/1254 b/changelog/12.0.3_2023-08-31/1254
@@ -0,0 +1,5 @@
+Bugfix: Connection name
+
+Connection name doesn't change immediately 
+
+https://github.com/owncloud/ios-app/issues/1254
diff --git a/changelog/12.0.3_2023-08-31/1262 b/changelog/12.0.3_2023-08-31/1262
@@ -0,0 +1,5 @@
+Bugfix: Unable to access files from Files.app
+
+In some cases it was not possible to access files from the Files.app.
+
+https://github.com/owncloud/ios-app/issues/1262
diff --git a/changelog/12.0.3_2023-08-31/1266 b/changelog/12.0.3_2023-08-31/1266
@@ -0,0 +1,5 @@
+Bugfix: File Provider Crash
+
+iOS invokes a FileProvider method with a nil value, which causes a crash.
+
+https://github.com/owncloud/ios-app/issues/1266
diff --git a/changelog/12.0.3_2023-08-31/1269 b/changelog/12.0.3_2023-08-31/1269
@@ -0,0 +1,5 @@
+Bugfix: Translation
+
+Updated translations from Transifex.
+
+https://github.com/owncloud/ios-app/pull/1269
diff --git a/changelog/12.0.3_2023-08-31/5747 b/changelog/12.0.3_2023-08-31/5747
@@ -0,0 +1,5 @@
+Bugfix: Open in Web for ownCloud 10
+
+Open in Web feature was not available for ownCloud 10 instances in the app.
+
+https://github.com/owncloud/enterprise/issues/5747
diff --git a/changelog/12.0.3_2023-08-31/5889 b/changelog/12.0.3_2023-08-31/5889
@@ -0,0 +1,5 @@
+Bugfix: Copy Item not working
+
+Copy and paste to a Space was not working
+
+https://github.com/owncloud/enterprise/issues/5889
diff --git a/fastlane/Fastfile b/fastlane/Fastfile
@@ -185,9 +185,8 @@ platform :ios do
           )
 
           puts("Build EMM iOS App…")
-          # Set EMM App-Icon for App Build
-          sh "mv ../ownCloud/Resources/Assets.xcassets/AppIcon.appiconset/ ../ownCloud/Resources/Assets.xcassets/AppIcon-regular.appiconset/"
-          sh "mv ../ownCloud/Resources/Assets.xcassets/AppIcon-emm.appiconset/ ../ownCloud/Resources/Assets.xcassets/AppIcon.appiconset/"
+          # Moving all EMM resources to the correct place
+          sh "cp -R  ../ownCloud/Resources/Theming/com.owncloud.ios-app.emm/* ../ownCloud/Resources/Theming/"
 
           # Build App
           owncloud_emm_build()
@@ -222,30 +221,9 @@ platform :ios do
 
         puts("Build ownCloud Online iOS App…")
 
-        # Moving the ownCloud.online Branding.plist to the correct place
-        sh "mv ../ownCloud/Resources/Theming/Branding.plist ../ownCloud/Resources/Theming/Branding-regular.plist"
-        sh "mv ../ownCloud/Resources/Theming/Branding-owncloud-online.plist ../ownCloud/Resources/Theming/Branding.plist"
-
-        # Set ownCloud.online Splashscreen Background for App Build
-        sh "mv ../ownCloud/Resources/Theming/branding-splashscreen-background.png ../ownCloud/Resources/Theming/branding-splashscreen-background-regular.png"
-        sh "mv ../ownCloud/Resources/Theming/branding-splashscreen-background-owncloud-online.png ../ownCloud/Resources/Theming/branding-splashscreen-background.png"
-
-        # Set ownCloud.online Splashscreen Logo for App Build
-        sh "mv ../ownCloud/Resources/Theming/branding-splashscreen.png ../ownCloud/Resources/Theming/branding-splashscreen-regular.png"
-        sh "mv ../ownCloud/Resources/Theming/branding-splashscreen-owncloud-online.png ../ownCloud/Resources/Theming/branding-splashscreen.png"
-
-        # Set ownCloud.online Branded Login Logo for App Build
-        sh "mv ../ownCloud/Resources/Theming/branding-login-logo.png ../ownCloud/Resources/Theming/branding-login-logo-regular.png"
-        sh "mv ../ownCloud/Resources/Theming/branding-login-logo-owncloud-online.png ../ownCloud/Resources/Theming/branding-login-logo.png"
-
-        # Set ownCloud.online Branded Login Background for App Build
-        sh "mv ../ownCloud/Resources/Theming/branding-login-background.png ../ownCloud/Resources/Theming/branding-login-background-regular.png"
-        sh "mv ../ownCloud/Resources/Theming/branding-login-background-owncloud-online.png ../ownCloud/Resources/Theming/branding-login-background.png"
-
-        # Set ownCloud.online App-Icon for App Build
-        sh "mv ../ownCloud/Resources/Assets.xcassets/AppIcon.appiconset/ ../ownCloud/Resources/Assets.xcassets/AppIcon-regular.appiconset/"
-        sh "mv ../ownCloud/Resources/Assets.xcassets/AppIcon-ownCloud-online.appiconset/ ../ownCloud/Resources/Assets.xcassets/AppIcon.appiconset/"
-
+        # Moving all ownCloud.online resources to the correct place
+        sh "cp -R  ../ownCloud/Resources/Theming/online.owncloud.ios-app/* ../ownCloud/Resources/Theming/"
+
         # Build App
         owncloud_online_build()
 
@@ -424,7 +402,7 @@ end
   end
 
   lane :generate_appicon do
-    iconPath = "ownCloud/Resources/Theming/icon-1024.png"
+    iconPath = "ownCloud/Resources/Theming/branding-icon.png"
     if File.exist?("../" + iconPath)
       appicon(
         appicon_image_file: iconPath,

diff --git a/fastlane/metadata-emm/en-US/release_notes.txt b/fastlane/metadata-emm/en-US/release_notes.txt
@@ -1,7 +1,3 @@
-Bug Fixes
-
-• Added missing Recents Group
-• Unable to authenticate using OpenID Connect
-• Attach files from third-party apps
-• Solves "Content unavailable" in Files.app
+• Bug Fixes
+Fixed File Provider, App Provider and layout issues.
 
diff --git a/fastlane/metadata-owncloud-online/en-US/release_notes.txt b/fastlane/metadata-owncloud-online/en-US/release_notes.txt
@@ -1,7 +1,3 @@
-Bug Fixes
-
-• Added missing Recents Group
-• Unable to authenticate using OpenID Connect
-• Attach files from third-party apps
-• Solves "Content unavailable" in Files.app
+• Bug Fixes
+Fixed File Provider, App Provider and layout issues.
 
diff --git a/fastlane/metadata/en-US/release_notes.txt b/fastlane/metadata/en-US/release_notes.txt
@@ -1,7 +1,3 @@
-Bug Fixes
-
-• Added missing Recents Group
-• Unable to authenticate using OpenID Connect
-• Attach files from third-party apps
-• Solves "Content unavailable" in Files.app
+• Bug Fixes
+Fixed File Provider, App Provider and layout issues.
 
diff --git a/fastlane/screenshots/bg_BG/keyword.strings b/fastlane/screenshots/bg_BG/keyword.strings
diff --git a/fastlane/screenshots/bg_BG/title.strings b/fastlane/screenshots/bg_BG/title.strings
diff --git a/fastlane/screenshots/de-DE/keyword.strings b/fastlane/screenshots/de-DE/keyword.strings
diff --git a/fastlane/screenshots/de-DE/title.strings b/fastlane/screenshots/de-DE/title.strings
diff --git a/ios-sdk b/ios-sdk
diff --git a/ownCloud File Provider/FileProviderContentEnumerator.h b/ownCloud File Provider/FileProviderContentEnumerator.h
@@ -26,6 +26,8 @@ NS_ASSUME_NONNULL_BEGIN
 {
 	NSMutableArray <FileProviderEnumeratorObserver *> *_enumerationObservers;
 	NSMutableArray <FileProviderEnumeratorObserver *> *_changeObservers;
+
+	NSHashTable<OCQuery *> *_didReturnAnyContentQueries;
 }
 
 @property(nonatomic,readonly,class) OCAsyncSequentialQueue *queue;