Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only]removed to do comment inside Trashbin #10424

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

S-Panta
Copy link
Contributor

@S-Panta S-Panta commented Oct 28, 2024

Description

I have uncommented and removed TODO because I don't find anything that should be done here. The comment isn't that clear. Deeper structure might suggest making sure the code works for files deep inside the folders, but when I tried creating files and deleting them, the code seemed to work.

Related Issue

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link

update-docs bot commented Oct 28, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@S-Panta S-Panta changed the title removed to do comment [tests-only]removed to do comment inside Trashbin Oct 28, 2024
@S-Panta S-Panta self-assigned this Oct 28, 2024
Copy link

sonarcloud bot commented Oct 28, 2024

@saw-jan saw-jan merged commit d91d189 into master Oct 28, 2024
2 checks passed
@saw-jan saw-jan deleted the remove-todo-from-trashbin branch October 28, 2024 09:39
ownclouders pushed a commit that referenced this pull request Oct 28, 2024
[tests-only]removed to do comment inside Trashbin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants