fix(semantic): do not create a global symbol for declare global {}

[DonIsaac]

Global augmentation declarations do not create a symbol named global, so neither should we.

[graphite-app]

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[DonIsaac]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat(ast): add TSModuleDeclarationName::binding_identifier() #6005
• fix(semantic): do not create a global symbol for declare global {} #6004 👈
• feat(parser)!: use BindingIdentifier for namespace declaration names #6003
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @DonIsaac and the rest of your teammates on Graphite

[codspeed-hq]

CodSpeed Performance Report

Merging #6004 will not alter performance

_{Comparing don/09-23-fix_semantic_do_not_create_a_global_symbol_for_declare_global_ (5238027) with don/09-23-feat_parser_use_bindingidentifier_for_namespace_declaration_names (b201de1)}

Summary

✅ 29 untouched benchmarks