Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(linter): re-use possible jest nodes across rules #6049

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

camchenry
Copy link
Collaborator

No description provided.

Copy link

graphite-app bot commented Sep 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Sep 25, 2024
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @camchenry and the rest of your teammates on Graphite Graphite

@camchenry
Copy link
Collaborator Author

The main issue I'm running into here is:

error[E0515]: cannot return value referencing local variable `jest_nodes`
   --> crates/oxc_linter/src/lib.rs:157:9
    |
150 |             for node in &jest_nodes {
    |                         ----------- `jest_nodes` is borrowed here
...
157 |         ctx_host.take_diagnostics()
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ returns a value referencing data owned by the current function

@camchenry camchenry force-pushed the 09-25-perf_linter_re-use_possible_jest_nodes_across_rules branch from 3f280ec to 9fe0bfe Compare October 2, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant