refactor(transformer): pre-allocate more stack space #6095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Sep 26, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
This was referenced Sep 26, 2024
|
This stack of PRs introducing But we can also use these more efficient stack structures in many other places in our codebase, so the impact will be more significant in aggregate, especially for stacks which get pretty deep e.g. |
CodSpeed Performance ReportMerging #6095 will not alter performanceComparing Summary
|
Merge activity
|
Dunqing
force-pushed
the
09-24-refactor_transformer_add_sparsestack_with_capacity_method
branch
from
e1a6472
to
e60ce50
Compare
Dunqing
pushed a commit
that referenced
this pull request
Sep 27, 2024
Pre-allocate 16 bytes for stacks in transforms that use them. Allocators usually support minimum of 16 bytes for allocations anyway. Now that we're using `SparseStack`, allocating decent capacity is now cheap.
Dunqing
force-pushed
the
09-27-refactor_transformer_pre-allocate_more_stack_space
branch
from
f2a5883
to
f191fb3
Compare
Dunqing
previously requested changes
Sep 27, 2024
Base automatically changed from
09-24-refactor_transformer_add_sparsestack_with_capacity_method
to
main
September 27, 2024 04:44
Boshen
reviewed
Sep 27, 2024
There was a problem hiding this comment.
FYI previous PR crashed somewhere https://github.com/oxc-project/monitor-oxc/actions/runs/11065170732/job/30744171583
Running Transformer.
thread 'main' panicked at /home/runner/work/monitor-oxc/oxc/crates/oxc_transformer/src/helpers/stack/standard.rs:341:9:
assertion failed: self.cursor < self.end
Boshen
pushed a commit
that referenced
this pull request
Sep 27, 2024
Fix incorrect debug assertion in `Stack`. The code itself was fine, but debug assertion was testing the wrong thing. This error was spotted by @Boshen: #6095 (review) Also add more debug asserts and change test so it fails before the fix in this PR.
overlookmotel
added a commit
that referenced
this pull request
Sep 27, 2024
Pre-allocate 16 bytes for stacks in transforms that use them. Allocators usually support minimum of 16 bytes for allocations anyway. Now that we're using `SparseStack`, allocating decent capacity is now cheap.
overlookmotel
force-pushed
the
09-27-refactor_transformer_pre-allocate_more_stack_space
branch
from
f191fb3
to
8146517
Compare
overlookmotel
changed the base branch from
main
to
09-27-refactor_transformer_add_wrapper_around_nonnull_
This was referenced Sep 27, 2024
overlookmotel
force-pushed
the
09-27-refactor_transformer_add_wrapper_around_nonnull_
branch
from
6a68db0
to
ea6c125
Compare
overlookmotel
added a commit
that referenced
this pull request
Sep 27, 2024
Pre-allocate 16 bytes for stacks in transforms that use them. Allocators usually support minimum of 16 bytes for allocations anyway. Now that we're using `SparseStack`, allocating decent capacity is now cheap.
overlookmotel
force-pushed
the
09-27-refactor_transformer_pre-allocate_more_stack_space
branch
from
8146517
to
e0f3c64
Compare
Pre-allocate 16 bytes for stacks in transforms that use them. Allocators usually support minimum of 16 bytes for allocations anyway. Now that we're using `SparseStack`, allocating decent capacity is now cheap.
Boshen
force-pushed
the
09-27-refactor_transformer_add_wrapper_around_nonnull_
branch
from
ea6c125
to
9ac80bd
Compare
Boshen
force-pushed
the
09-27-refactor_transformer_pre-allocate_more_stack_space
branch
from
e0f3c64
to
58fd6eb
Compare
Base automatically changed from
09-27-refactor_transformer_add_wrapper_around_nonnull_
to
main
September 27, 2024 17:05
graphite-app
bot
deleted the
09-27-refactor_transformer_pre-allocate_more_stack_space
branch
Boshen
added a commit
that referenced
this pull request
Sep 28, 2024
## [0.30.4] - 2024-09-28 ### Bug Fixes - 8582ae3 codegen: Missing parentheses if there is a pure comment before a NewExpression as a ComputedMemberExpression's callee (#6105) (Dunqing) - fd6798f parser: Remove unintended `pub Kind` (#6109) (Boshen) - 6f98aad sourcemap: Align sourcemap type with Rollup (#6133) (Boshen) - 64d4756 transformer: Fix debug assertion in `Stack` (#6106) (overlookmotel) ### Performance - 05852a0 codegen: Do not check whether there are annotation comments or not if we don't preserve annotation comments (#6107) (Dunqing) ### Documentation - 26a273a oxc-transform: Update README (Boshen) - e2c5baf transformer: Fix formatting of README (#6111) (overlookmotel) ### Refactor - 2090fce semantic: Fix lint warning in nightly (#6110) (overlookmotel) - 7bc3988 transformer: Remove dead code (#6124) (overlookmotel) - 07fe45b transformer: Exponentiation operator: convert to match (#6123) (overlookmotel) - 4387845 transformer: Share `TypeScriptOptions` with ref not `Rc` (#6121) (overlookmotel) - 09e41c2 transformer: Share `TransformCtx` with ref not `Rc` (#6118) (overlookmotel) - 58fd6eb transformer: Pre-allocate more stack space (#6095) (overlookmotel) - 9ac80bd transformer: Add wrapper around `NonNull` (#6115) (overlookmotel) - c50500e transformer: Move common stack functionality into `StackCommon` trait (#6114) (overlookmotel) - 9839059 transformer: Simplify `StackCapacity` trait (#6113) (overlookmotel) --------- Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-allocate 16 bytes for stacks in transforms that use them. Allocators usually support minimum of 16 bytes for allocations anyway. Now that we're using
SparseStack, allocating decent capacity is now cheap.