Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linter): add category to completed rules #6182

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shulaoda
Copy link
Contributor

I noticed that some rules have been completed, but their category is still set to nursery.

Copy link

graphite-app bot commented Sep 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-linter Area - Linter label Sep 30, 2024
Copy link

codspeed-hq bot commented Sep 30, 2024

CodSpeed Performance Report

Merging #6182 will not alter performance

Comparing shulaoda:chore/add-category-for-completed-rule (bee577d) with main (02fedf5)

Summary

✅ 29 untouched benchmarks

@github-actions github-actions bot added the A-cli Area - CLI label Sep 30, 2024
@Boshen
Copy link
Member

Boshen commented Oct 1, 2024

I don't think these rules are completed in a sense that they are usable? They haven't been tested properly in real projects yet. What I do is use all the oxlint-ecosystem-ci projects locally with the rules enabled individually.

@Boshen Boshen marked this pull request as draft October 1, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area - CLI A-linter Area - Linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants