Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(allocator): use lower bound of size hint when creating Vecs from an iterator #6194

Conversation

DonIsaac
Copy link
Collaborator

No description provided.

Copy link

graphite-app bot commented Sep 30, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@DonIsaac DonIsaac added the C-performance Category - Solution not expected to change functional behavior, only performance label Sep 30, 2024 — with Graphite App
Copy link
Collaborator Author

1 similar comment
Copy link
Collaborator Author

@DonIsaac DonIsaac marked this pull request as ready for review September 30, 2024 22:42
Copy link

codspeed-hq bot commented Sep 30, 2024

CodSpeed Performance Report

Merging #6194 will not alter performance

Comparing don/09-30-perf_allocator_use_lower_bound_of_size_hint_when_creating_vecs_from_an_iterator (5db9b30) with main (70d4c56)

Summary

✅ 29 untouched benchmarks

Copy link
Collaborator

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Oct 1, 2024
Copy link

graphite-app bot commented Oct 1, 2024

Merge activity

  • Sep 30, 8:06 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 30, 8:06 PM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • Sep 30, 8:11 PM EDT: overlookmotel merged this pull request with the Graphite merge queue.

@overlookmotel overlookmotel force-pushed the don/09-30-perf_allocator_use_lower_bound_of_size_hint_when_creating_vecs_from_an_iterator branch from 0af64c6 to 5db9b30 Compare October 1, 2024 00:07
@graphite-app graphite-app bot merged commit 5db9b30 into main Oct 1, 2024
27 checks passed
@graphite-app graphite-app bot deleted the don/09-30-perf_allocator_use_lower_bound_of_size_hint_when_creating_vecs_from_an_iterator branch October 1, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue C-performance Category - Solution not expected to change functional behavior, only performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants