Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minifier): fold object constructor #6232

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

camchenry
Copy link
Collaborator

@camchenry camchenry commented Oct 1, 2024

This will fold expressions like new Object() to {}. Based on the closure compiler tests: https://github.com/google/closure-compiler/blob/b7e380b6320a52ce7fbac0334ede00d6a8c92fad/test/com/google/javascript/jscomp/PeepholeSubstituteAlternateSyntaxTest.java#L78.

This is outside my usual area, so feedback is welcome.

Copy link

graphite-app bot commented Oct 1, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the A-minifier Area - Minifier label Oct 1, 2024
@camchenry camchenry force-pushed the 10-01-feat_minifier_fold_object_constructor branch from 0cac0ce to 41d8d1f Compare October 1, 2024 22:51
@camchenry camchenry marked this pull request as ready for review October 1, 2024 22:54
Copy link

codspeed-hq bot commented Oct 1, 2024

CodSpeed Performance Report

Merging #6232 will not alter performance

Comparing 10-01-feat_minifier_fold_object_constructor (41d8d1f) with main (0400ff9)

Summary

✅ 29 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-minifier Area - Minifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants