feat(allocator): introduce Vec::from_array_in
#7331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
github-actions
bot
added
A-minifier
CodSpeed Performance ReportMerging #7331 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
11-17-feat_allocator_introduce_vec_from_array_in_
branch
2 times, most recently
from
047c30d
to
f34b427
Compare
This was referenced Nov 17, 2024
Merge activity
|
Because we lack specialization in stable Rust, `Vec::from_iter_in` is unable to take advantage of the fact that `[T; N]` has a statically knowable size. Introduce `Vec::from_array_in` for this case, which should be able to create the `Vec` with a single static-sized memcpy, or may allow the compiler to see that it can construct the array directly in the arena, rather than construct on stack and then copy to the arena. Also add a corresponding `AstBuilder::vec_from_array` method, and use it in various places in codebase.
Boshen
force-pushed
the
11-17-feat_allocator_introduce_vec_from_array_in_
branch
from
f34b427
to
39afb48
Compare
Boshen
pushed a commit
that referenced
this pull request
Nov 18, 2024
Use `AstBuilder::vec_from_array` introduced in #7331 in the transformer, in place of creating a `Vec` with `Vec::with_capacity` and then pushing values to it.
graphite-app
bot
deleted the
11-17-feat_allocator_introduce_vec_from_array_in_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we lack specialization in stable Rust,
Vec::from_iter_inis unable to take advantage of the fact that[T; N]has a statically knowable size.Introduce
Vec::from_array_infor this case, which should be able to create theVecwith a single static-sized memcpy, or may allow the compiler to see that it can construct the array directly in the arena, rather than construct on stack and then copy to the arena.Also add a corresponding
AstBuilder::vec_from_arraymethod, and use it in various places in codebase.