Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm feature flag instead of platform-dependent dependencies #134

Open
lovasoa opened this issue Nov 2, 2024 · 0 comments
Open

wasm feature flag instead of platform-dependent dependencies #134

lovasoa opened this issue Nov 2, 2024 · 0 comments

Comments

@lovasoa
Copy link

lovasoa commented Nov 2, 2024

Hello !

Currently, this crate fails to compile in wasm, unless the wasm feature flag is provided.

This comes from the fact that wasm-specific dependencies are specified under a feature flag instead of being specified as platform-specific dependencies :

wasm = ["dep:web-time"]

Using platform-specific dependencies with

[target.'cfg(target_family = "wasm")'.dependencies]
some_wasm_specific_dep = "0.0.0"

would allow the code to compile for wasm without having to specify a feature flag.

This is especially useful to users for whom clarabel is a sub-dependency.

See rust-or/good_lp#63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant