add latency to log messages #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luqmana
approved these changes
Aug 3, 2023
dropshot/src/server.rs
Outdated
| @@ -848,7 +851,8 @@ async fn http_request_handle_wrap<C: ServerContext>( | |||
| Ok(response) => { | |||
| // TODO-debug: add request and response headers here | |||
| info!(request_log, "request completed"; | |||
| "response_code" => response.status().as_str().to_string() | |||
| "response_code" => response.status().as_str().to_string(), | |||
There was a problem hiding this comment.
This was pre-existing, but is there any reason the extra to_string() allocation is needed here (and above)?
There was a problem hiding this comment.
I think it's probably old code from before I really grokked when slog needs an owned value vs. when it doesn't. I can include this improvement into this PR too.
david-crespo
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #692. Okay, I figured it'd be easy, but this was even easier than I expected. Sorry it took so long.