Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move interleaved uncontained memory test into cannot_access_uncontained_memory #1758

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aapoalas
Copy link
Contributor

Pretty-much zero-benefit PR but it started bugging me that cannot_access_uncontained_memory was "spuriously" failing when I'd added the "two good slices interleaved with uncontained memory" case into the fake table.

Well, it wasn't spuriously failing. It was just already testing what the cannot_access_slice_spanning_over_uncontained_memory test case I added tests, and it was failing because at that point the I still had my attempted improved algorithm in the branch.

So in effect: The last added test case can be just replaced with a single addition into the fake table, after which the existing uncontained memory access test takes care of testing that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant