Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EMC2305 manufacturer ID #1877

Merged
merged 17 commits into from
Sep 27, 2024
Merged

Fix EMC2305 manufacturer ID #1877

merged 17 commits into from
Sep 27, 2024

Conversation

mkeeter
Copy link
Collaborator

@mkeeter mkeeter commented Sep 23, 2024

...and remove disclaimer, now that we've tested things

@mkeeter
Copy link
Collaborator Author

mkeeter commented Sep 25, 2024

We're going to leave this open while Nathanael fights with the power sequencing on the FPGA, to avoid committing a bunch of FPGA images to the repo history.

Copy link
Contributor

@nathanaelhuffman nathanaelhuffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can get rid of some of the TODO-ish comments in grapefruit-seq-server's main

// Do we have to send the synchronization word ourself, or is it built
        // into the bitstream?
        // Same with device ID check

at line 164 and

the TODO at line 177/178 also.

GH won't let me comment there since you didn't touch them.

Otherwise lgtm!

@mkeeter mkeeter enabled auto-merge (squash) September 27, 2024 13:16
@mkeeter mkeeter merged commit c47b0a8 into master Sep 27, 2024
106 checks passed
@mkeeter mkeeter deleted the fix-emc2305-mfg-id branch September 27, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants