-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EMC2305 manufacturer ID #1877
Conversation
We're going to leave this open while Nathanael fights with the power sequencing on the FPGA, to avoid committing a bunch of FPGA images to the repo history. |
bebbec9
to
bc97a8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can get rid of some of the TODO-ish comments in grapefruit-seq-server's main
// Do we have to send the synchronization word ourself, or is it built
// into the bitstream?
// Same with device ID check
at line 164 and
the TODO at line 177/178 also.
GH won't let me comment there since you didn't touch them.
Otherwise lgtm!
21512b7
to
a243ea6
Compare
...and remove disclaimer, now that we've tested things