Support the NUCLEO-STM32F429ZI board. #1917
Open
+490
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drives the LEDs through the stm32xx-sys task.
labbott
reviewed
Nov 11, 2024
hawkw
reviewed
Nov 12, 2024
Comment on lines
+540
to
+541
| /////////////////////////////////////////////////////////////////////////////// | ||
| // The STM32F4 specific bits. |
There was a problem hiding this comment.
Take it or leave it: I wonder if we might want to move the board-specific bits into submodules with #[cfg(feature = <board feature>] on them, instead of sticking a cfg attribute on each function and constant? We could do the same for the existing F3 stuff. The code might read a little nicer that way. But, it's up to you.
There was a problem hiding this comment.
That sounds like a good follow-up PR. I just wanted to share what I'd done to make it run on the board I had.
Typo s/distinguish/distinguishes Co-authored-by: Eliza Weisman <eliza@elizas.website>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this new board, we get the user-led task to drive the LEDs via the
stm32xx-systask, like it did on the STM32H7 based boards.This PR also updates the existing STM32F4-DISCOVERY support in the
user-ledtask (which uses the STM32F407) to also use thestm32xx-systask for driving LEDs. This leaves just the STM32F3-DISCOVERY using the direct-access approach.The STM32 UART support also now understands both the F429 and F407, but I didn't yet hook up a terminal to see if it works.
The demo was tested on a NUCLEO-STM32F429ZI. Unfortunately I don't have a STM32F4-DISCOVERY to hand to check I didn't break anything there.
This was literally my first introduction to Hubris, so hopefully I got it all mostly right. The changes took about five hours, all told. Much of that was diagnosing the
stm32xx-sysconstantly restarting - it was because it didn't have permission to write to the GPIO address range.