Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail if humility readvar doesn't find the variable #407

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Fail if humility readvar doesn't find the variable #407

merged 2 commits into from
Jul 26, 2023

Conversation

mkeeter
Copy link
Contributor

@mkeeter mkeeter commented Jul 26, 2023

Previously, it would return successfully, without any warnings.

@mkeeter mkeeter requested a review from bcantrill July 26, 2023 20:49
lzrd
lzrd approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@lzrd lzrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A friendlier error message on name not found. Looks good.

@mkeeter mkeeter merged commit 1840ece into master Jul 26, 2023
11 checks passed
@mkeeter mkeeter deleted the print-err-on-missing branch July 26, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzrd lzrd lzrd approved these changes

@bcantrill bcantrill Awaiting requested review from bcantrill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkeeter @lzrd