Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OZ-573: Add support for SSO with new configurations #97

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

corneliouzbett
Copy link
Contributor

@corneliouzbett corneliouzbett commented Nov 4, 2024

Issue: https://mekomsolutions.atlassian.net/browse/OZ-573

This PR brings in required configs to support SSO in Ozone FOSS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rbuisson @enyachoke I've introduced a new folder under both configs/ and binaries/ for SSO binaries & configs. This is to effectively exclude them via docker compose files & volumes. What do you think about this approach? are there alternatives?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not seem right to add a new folder in there at all. I would prefer to have the files (maybe with -sso suffix or something) rather than a new folder altogether. Is that possible.
I can see in the PR some changes on the configs/ folder but could not see anything in binaries/.

Is this done at build time? and how does that look in the final package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see in the PR some changes on the configs/ folder but could not see anything in binaries/.
Is this done at build time?

Yes, for binaries, it's added at build time.

how does that look in the final package?

ozone/
├── binaries/
│   ├── openmrs/
│   │   └── ...
│   ├── openmrs_sso/
│   │   └── modules/
│   │       └── oauth2login-1.4.0.omod
│   ├── superset
│   └── ...
├── configs/
│   ├── openmrs
│   ├── openmrs_sso/
│   │   ├── frontend_config/
│   │   │   └── ozone-sso-frontend-config.jso
│   │   ├── initializer_config
│   │   ├── properties/
│   │   │   └── oauth2.properties
│   │   └── ...
│   └── ...
├── data
└── ozone-info.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to have the files (maybe with -sso suffix or something) rather than a new folder altogether. Is that possible.

The challenge here is that we are mounting everything in the modules directory. We need to find a way to exclude some modules, specifically the oauth2login module, when SSO is not enabled.

Docker Compose does not support wildcard filtering directly when mounting volumes. we need to specify the exact paths for the volumes we want to mount. If we need to exclude certain files or directories, we would typically handle this outside of Docker Compose, such as by organizing files in a way that allows us to mount only the desired directories/files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants