Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update find #17

Merged
merged 4 commits into from
Dec 27, 2023
Merged

Update find #17

merged 4 commits into from
Dec 27, 2023

Conversation

p-gw
Copy link
Owner

@p-gw p-gw commented Dec 27, 2023

Changes the function signature of find to use ReliabilityMeasure instead of low-level functions.

Also implements Term.Progress.ProgressBar() to reduce number of dependencies.

closes #15
closes #16

@p-gw p-gw linked an issue Dec 27, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a703943) 32.19% compared to head (f7ad540) 79.63%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #17       +/-   ##
===========================================
+ Coverage   32.19%   79.63%   +47.44%     
===========================================
  Files           9       11        +2     
  Lines         292      329       +37     
===========================================
+ Hits           94      262      +168     
+ Misses        198       67      -131     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@p-gw p-gw changed the title pass ReliabilityMeasure to find Update find Dec 27, 2023
@p-gw p-gw marked this pull request as ready for review December 27, 2023 15:05
@p-gw p-gw merged commit 63a8a26 into main Dec 27, 2023
5 of 6 checks passed
@p-gw p-gw deleted the 15-pass-reliabilitymeasure-to-find branch December 27, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Terms ProgressBar Pass ReliabilityMeasure to find
1 participant