Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webui #24

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add webui #24

wants to merge 6 commits into from

Conversation

dynm
Copy link

@dynm dynm commented Nov 24, 2023

image

@dynm dynm mentioned this pull request Nov 24, 2023
@pepijnmm
Copy link

Works great! also nice that you don't have to fiddle with the environmental variables for the api keys.
One thing to note that should maybe be added is to create the "Output Folder Path" if it doesn't exist. as in if it doesn't exist it also can't create the error log. Other than that just curious. why can't we change the output folder path?

@dynm
Copy link
Author

dynm commented Jan 3, 2024

The reason is that I initially designed this with Docker in mind, using file volume mapping to the output folder path, so I didn't consider the need to modify this path. In future versions, I will add the functionality to change the path.

@@ -1,17 +1,14 @@
# Use an official Python runtime as a parent image
FROM python:3.11-slim-bookworm

COPY requirements.txt /app_src/requirements.txt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not need to copy a file, as the entire project workspace suppose to be mounted through the docker volume.

# Set the working directory to /app
WORKDIR /app
# Add current directory code to docker
COPY . /app_src
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same... just use:

docker run -it --rm -v $(pwd):/app ....

# Set the working directory to /app
WORKDIR /app
# Add current directory code to docker
COPY . /app_src

# Set this as the default command
ENTRYPOINT [ "python", "/app_src/epub_to_audiobook.py" ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no new line at the end of file

ports:
- 7860:7860
volumes:
- ./audiobook_output:/audiobook_output
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no new line at the end of the file

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic!!!
Will definitely merge it in!

socksio==1.0.0
gradio==4.7.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no new line at the end :D

ui.load(utils.read_log, inputs=None, outputs=log_textarea, every=1)
ui.load(conversion.list_files, inputs=None, outputs=[file_list], every=1)

ui.queue().launch(server_name=cmd_args.listen, server_port=cmd_args.port, share=cmd_args.share)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new line at the end ahahahha

Overall looks awesome, though it was implemented before major project refactoring.
Could you please update this PR to match current project version and I would love to merge it in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants