-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add webui #24
base: main
Are you sure you want to change the base?
Add webui #24
Conversation
dynm
commented
Nov 24, 2023
Works great! also nice that you don't have to fiddle with the environmental variables for the api keys. |
The reason is that I initially designed this with Docker in mind, using file volume mapping to the output folder path, so I didn't consider the need to modify this path. In future versions, I will add the functionality to change the path. |
@@ -1,17 +1,14 @@ | |||
# Use an official Python runtime as a parent image | |||
FROM python:3.11-slim-bookworm | |||
|
|||
COPY requirements.txt /app_src/requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do not need to copy a file, as the entire project workspace suppose to be mounted through the docker volume.
# Set the working directory to /app | ||
WORKDIR /app | ||
# Add current directory code to docker | ||
COPY . /app_src |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same... just use:
docker run -it --rm -v $(pwd):/app ....
# Set the working directory to /app | ||
WORKDIR /app | ||
# Add current directory code to docker | ||
COPY . /app_src | ||
|
||
# Set this as the default command | ||
ENTRYPOINT [ "python", "/app_src/epub_to_audiobook.py" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no new line at the end of file
ports: | ||
- 7860:7860 | ||
volumes: | ||
- ./audiobook_output:/audiobook_output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no new line at the end of the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic!!!
Will definitely merge it in!
socksio==1.0.0 | ||
gradio==4.7.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no new line at the end :D
ui.load(utils.read_log, inputs=None, outputs=log_textarea, every=1) | ||
ui.load(conversion.list_files, inputs=None, outputs=[file_list], every=1) | ||
|
||
ui.queue().launch(server_name=cmd_args.listen, server_port=cmd_args.port, share=cmd_args.share) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No new line at the end ahahahha
Overall looks awesome, though it was implemented before major project refactoring.
Could you please update this PR to match current project version and I would love to merge it in