-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JSON Schema generation for union dtypes #39
Conversation
Pull Request Test Coverage Report for Build 12325636494Details
💛 - Coveralls |
…n schema generation
this is the damndest thing... I can replicate #38 when i run just the pipe union tests like
but i can't replicate it if i select any other cases - here the
or generically
pydantic must be doing some schema caching..... |
oh omg this is yet another nptyping bug. apparently |
I think the reason nptyping doesn't create a new type every time is for type equality comparisons, so i'm preserving that for now by adding additional type information in the key for the dict that stashes them, but these will go away in 2.0 when we finally are rid of nptyping |
ah, that's better, nothing like correctly failing tests to make you feel sane again |
…etadata in json schema
Fix the json schema half of: #38