Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initialize method to InternetChecksum #1267

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

p-sawicki
Copy link

I would like to propose adding a new method to the InternetChecksum extern which would initialize the incremental checksum computation with the initial checksum value extracted from a header.

The motivation behind the method is that currently to achieve this, one needs to call the subtract method which may not be obvious to someone not familiar with the exact formula used for computation so a separate method with a more obvious name would be helpful. Another name considered for this method is preload.

Implementation will be simple because in compilers that already support PSA's interface, ck.initialize(chksum); can be transformed to ck.clear(); ck.subtract(chksum);

Copy link
Collaborator

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants