Add initialize method to InternetChecksum #1267
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to propose adding a new method to the
InternetChecksum
extern which would initialize the incremental checksum computation with the initial checksum value extracted from a header.The motivation behind the method is that currently to achieve this, one needs to call the
subtract
method which may not be obvious to someone not familiar with the exact formula used for computation so a separate method with a more obvious name would be helpful. Another name considered for this method ispreload
.Implementation will be simple because in compilers that already support PSA's interface,
ck.initialize(chksum);
can be transformed tock.clear(); ck.subtract(chksum);