Try to get tox working on a newer Python version #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. @@ Coverage Diff @@
## master #286 +/- ##
=======================================
Coverage 95.78% 95.78%
=======================================
Files 28 28
Lines 3958 3958
Branches 798 798
=======================================
Hits 3791 3791
Misses 98 98
Partials 69 69 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Tests look legit, better do a workflow dispatch as well to be safe https://github.com/pace-neutrons/Euphonic/actions/runs/6051778082 |
|
All good. Thanks @mducle ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be good if Tox didn't need to run on Python 3.7, but we hit some mysterious issues with Windows runners.
Tried removing the login shell requirement from test runner, didn't help.
@mducle Edit: Problem was with anaconda default packages. Switching to
conda-forgeseems to solve the problems.Whilst debugging the issues I used a lot of force-commits and messed up the history... so decided to junk it to leave just one commit. Old commits are here