Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: load QpointPhononModes with one q-point from JSON #293

Merged
merged 3 commits into from
Feb 15, 2024

Conversation

ajjackson
Copy link
Collaborator

Closes #292

Copy link
Contributor

github-actions bot commented Feb 15, 2024

Test Results

0 files   -     21  0 suites   - 21   0s ⏱️ - 1h 21m 25s
0 tests  -  1 049  0 ✅  -  1 043  0 💤  -   6  0 ❌ ±0 
0 runs   - 21 903  0 ✅  - 21 777  0 💤  - 126  0 ❌ ±0 

Results for commit 89e41c6. ± Comparison against base commit 0080886.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0080886) 95.85% compared to head (89e41c6) 95.85%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #293   +/-   ##
=======================================
  Coverage   95.85%   95.85%           
=======================================
  Files          28       28           
  Lines        3982     3982           
  Branches      803      803           
=======================================
  Hits         3817     3817           
  Misses         97       97           
  Partials       68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ajjackson ajjackson enabled auto-merge (rebase) February 15, 2024 15:25
@ajjackson ajjackson merged commit 7608b14 into master Feb 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot load QpointPhononModes JSON with only one q-point
2 participants