Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spglib 2.4 compatibility: handle TypeError when passing empty cell #298

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Spglib 2.4 compatibility: handle TypeError when passing empty cell #298

merged 3 commits into from
Apr 18, 2024

Commits on Apr 18, 2024

  1. Spglib 2.4 compatibility: handle TypeError when passing empty cell 

    Some sanity-checking has been added to spglib and now this scenario
leads to a TypeError before the SymmetryDetectionError is reached.
    @ajjackson
    ajjackson committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    481e8da View commit details
    Browse the repository at this point in the history

  2. Check explicitly for empty cell when handling spglib 2.4 TypeError 

    The "positions has to be" string can also arise from other
inconsistencies in data size, which we might be less happy about.
    @ajjackson
    ajjackson committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    7060403 View commit details
    Browse the repository at this point in the history

  3. Changelog update

    @ajjackson
    ajjackson committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    64c3e2c View commit details
    Browse the repository at this point in the history