Test Brille fix #304
Merged
Test Brille fix #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, the "all" test with all optional dependencies passes, but the brille-only test fails. Let's see if we can figure out which dependency drives this. |
|
Ah, I don't think it's dependency-related; that's just the only setup which runs the main Brille interface tests. |
ajjackson
force-pushed
the
test-brille-fix
branch
from
05dc0f3
to
870a9ef
Compare
Check if Brille updates have resolved the issue
|
This looks very promising, but the CI is being brought down by an unrelated deprecation warning! (There is a particular test that is supposed to pass without any warnings...) The issues seems to lie inside an upstream library (SeeK-path is annoying spglib) so for now I will suppress it. |
ajjackson
force-pushed
the
test-brille-fix
branch
from
243dacf
to
8dd44f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test updates to Brille build system brille/brille#100