-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement web JSON export #318
Open
ajjackson
wants to merge
18
commits into
master
Choose a base branch
from
web-json
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
934934d
Implement web JSON export
ajjackson 750df2a
Try removing breaks and repeated q-points, setting line_breaks
ajjackson 31b60af
Pass x_tick_labels from seekpath; allow repeat points with small pad
ajjackson 7ee6196
Use standard library Counter to implement chemical formula
ajjackson 80cea6c
Fixed x-axis values for discontinuities
ajjackson 7dd02f2
Apply mass-weighting to modes for web JSON
ajjackson 10621c4
More tweaks to web json line_breaks indices
ajjackson e53b23d
Tweak web-json breakpoints: LO-TO also looks good now
ajjackson 67dda66
Move phonon-web-json exporter to separate file; implement --title
ajjackson 8049794
Cleaner duplicate-qpt manipulation
ajjackson 836faaf
Don't expand duplicate q-points, just find them
ajjackson 5af1228
Remove redundant list()
ajjackson 73a2598
Use None as fallback/default for plot titles
ajjackson 0d3af3b
Rework label-combining logic for ease of understanding
ajjackson e944fa8
Fix packaging of new submodule
ajjackson 8d8e415
Update euphonic/cli/utils.py
ajjackson 0112dea
Review feedback ( @oerc0122 )
ajjackson 9a1e9e3
Linting
ajjackson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warrant using a ternary if?
Would it be better to use
None
? Is there a reason a user might want to have an empty title?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the root of the problem is inconsistency 🙈
I guess the answer is to modify some of the other code to allow None as well, then it can be used as a default here and '' remains available as a way to specify "no seriously I don't want a title"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I would say that's a different issue and if this is the behaviour elsewhere that's fine. May want to make an issue even if it just sits there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix required fewer changes than I expected, let's give it a try