Skip to content

Commit

Permalink
Merge pull request #38 from paceaux/paceaux/issue36
Browse files Browse the repository at this point in the history
Paceaux/issue36
  • Loading branch information
paceaux authored Apr 3, 2024
2 parents fa5a5fe + 99df8d8 commit e1a9659
Show file tree
Hide file tree
Showing 5 changed files with 1,359 additions and 385 deletions.
13 changes: 11 additions & 2 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,22 @@
"version": "0.2.0",
"configurations": [
{
"type": "pwa-node",
"type": "node",
"request": "launch",
"name": "Launch Program",
"args": [
"-u", // url
"https://frankmtaylor.com/sitemap.xml",
"-l", // limit. raise or lower for more pages AND screenshots
"10",
"-c", // screengrabs.
"-s", // the selector
"h1"
],
"skipFiles": [
"<node_internals>/**"
],
"program": "${workspaceFolder}\\index.js"
"program": "${workspaceFolder}/cli.js"
}
]
}
12 changes: 10 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,17 @@ Pages not showing up that should? Check the `log.txt` for any issues.

- Node LTS (as of September 2023, Node 18.16.0)

- If you want to use the `-d` or `-c` (`--isSpa` and `--takeScreenshots` options), this requires Puppeteer which in turn requires Chromium.
#### Some possible Puppeteer setup for Mac Users

- If running this on a Mac, be sure you install chromium without a quarantine flag: `brew install chromium --no-quarantine`
If you want to use the `-d` or `-c` (`--isSpa` and `--takeScreenshots` ) options, this requires Puppeteer which in turn requires Chromium.

You may (or may not) need `PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true` and `PUPPETEER_EXECUTABLE_PATH` environment variables set. They were necessary for older versions of Puppeteer and seem to be unnecessary for new ones.

If you're having issues, run `printenv` in your terminal to see if those variables are set. If they are, you may need to unset them with `unset PUPPETEER_SKIP_CHROMIUM_DOWNLOAD` and `unset PUPPETEER_EXECUTABLE_PATH`. Then `source ~/.bashrc` or `source ~/.zshrc` to be sure, and run `printenv` once again.

But if they aren't set, you may need to do this.

After you play with those variables, reinstall this package.

### Running on-demand

Expand Down
Loading

0 comments on commit e1a9659

Please sign in to comment.