Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upd(apx): 2.4.0 -> 2.4.3 #6394

Merged
merged 14 commits into from
Sep 12, 2024
Merged

upd(apx): 2.4.0 -> 2.4.3 #6394

merged 14 commits into from
Sep 12, 2024

Conversation

souhaiebtar
Copy link
Contributor

No description provided.

@souhaiebtar
Copy link
Contributor Author

the problem is not related to the package but some golang package can't be download throw proxy,

"dial tcp: lookup proxy.golang.org on 127.0.0.11:53: read udp "

@Xdavius
Copy link
Contributor

Xdavius commented Sep 5, 2024

the problem is not related to the package but some golang package can't be download throw proxy,

"dial tcp: lookup proxy.golang.org on 127.0.0.11:53: read udp "

add this variable to the pacscript

external_connection=true

#6383 (comment)

This script wasn't maintained. It may need some adjustments.

Copy link
Contributor Author

@souhaiebtar souhaiebtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to allow package access to internet during installation

@souhaiebtar
Copy link
Contributor Author

the problem is not related to the package but some golang package can't be download throw proxy,
"dial tcp: lookup proxy.golang.org on 127.0.0.11:53: read udp "

add this variable to the pacscript

external_connection=true

#6383 (comment)

This script wasn't maintained. It may need some adjustments.

think you, i made a change as advised to allow package access to internet during installation

@Elsie19
Copy link
Member

Elsie19 commented Sep 7, 2024

Fix the title to conform to our standards, as explained in our docs. You can also look at past PRs to get an idea of how to format the title if you're unsure.


You gotta play by the rules

@vigress8 vigress8 changed the title update apx-git to 2.4.3 upd(apx-git): 2.4.0 -> 2.4.3 Sep 10, 2024
@vigress8
Copy link
Collaborator

vigress8 commented Sep 10, 2024

Build fails because apx's Makefile uses sudo, which is bad practice and not supported by Pacstall.
For a quick fix, please patch the Makefile like this in prepare()

sed -i 's/sudo //' Makefile

Edit: once Vanilla-OS/apx#397 is merged this will be fixed.

@kbdharun
Copy link

Hi, We have merged the Makefile PR upstream, can someone retrigger the failing jobs?

@vigress8
Copy link
Collaborator

vigress8 commented Sep 11, 2024

I retriggered them, but there's now an error I don't understand on debian:stable
https://github.com/pacstall/pacstall-programs/actions/runs/10736150513/job/29971996728?pr=6394#step:11:867
Gonna take a guess this is due to the outdated Golang?

Edit: Nevermind, you've indeed specified Go 1.22 in go.mod

@souhaiebtar
Copy link
Contributor Author

Fix the title to conform to our standards, as explained in our docs. You can also look at past PRs to get an idea of how to format the title if you're unsure.

You gotta play by the rules

my mistake, i will try to read the documentation and i will do as you asked

@souhaiebtar souhaiebtar changed the title upd(apx-git): 2.4.0 -> 2.4.3 upd(apx): 2.4.0 -> 2.4.3 Sep 12, 2024
@vigress8
Copy link
Collaborator

Sorry, I assumed you were inactive, and I edited the pacscript to use Golang 1.22
The sudo patch is not necessary anymore since I submitted a PR upstream that fixed the issue, so you can remove that line

@souhaiebtar
Copy link
Contributor Author

Sorry, I assumed you were inactive, and I edited the pacscript to use Golang 1.22 The sudo patch is not necessary anymore since I submitted a PR upstream that fixed the issue, so you can remove that line

ok my mistake, i will remove the line with sudo

Copy link
Collaborator

@vigress8 vigress8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add

export PATH=/usr/lib/go-1.22/bin:${PATH}

To prepare(), since Go 1.22 is not in PATH by default

packages/apx-git/apx-git.pacscript Outdated Show resolved Hide resolved
Co-authored-by: V. <150687949+vigress8@users.noreply.github.com>
@souhaiebtar
Copy link
Contributor Author

Add

export PATH=/usr/lib/go-1.22/bin:${PATH}

To prepare(), since Go 1.22 is not in PATH by default

do i still need to add this line ?

@vigress8
Copy link
Collaborator

Yes

because go 1.22 is not in the default path
@souhaiebtar
Copy link
Contributor Author

Add

export PATH=/usr/lib/go-1.22/bin:${PATH}

To prepare(), since Go 1.22 is not in PATH by default

do i still need to add this line ?

it's still reporting that go not found, do you have an idea how to resolve ?

@vigress8
Copy link
Collaborator

It's my mistake. That export should be done in build(), right before calling make

@souhaiebtar
Copy link
Contributor Author

It's my mistake. That export should be done in build(), right before calling make

thank you, i think it's more my mistake than yours, i wanted to help but it ended up by you @vigress8 doing all the work

@Elsie19 Elsie19 merged commit 6f59a8e into pacstall:master Sep 12, 2024
19 of 21 checks passed
@Elsie19 Elsie19 added the Update Package Use this to request pacscript update label Sep 12, 2024
@Elsie19
Copy link
Member

Elsie19 commented Sep 12, 2024

@souhaiebtar can you please make a PR that adds the line incompatible=("*:bookworm"). We forgot that before this was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Update Package Use this to request pacscript update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants