-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upd(apx): 2.4.0
-> 2.4.3
#6394
upd(apx): 2.4.0
-> 2.4.3
#6394
Conversation
for more information, see https://pre-commit.ci
the problem is not related to the package but some golang package can't be download throw proxy, "dial tcp: lookup proxy.golang.org on 127.0.0.11:53: read udp " |
add this variable to the pacscript
This script wasn't maintained. It may need some adjustments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update to allow package access to internet during installation
think you, i made a change as advised to allow package access to internet during installation |
Build fails because apx's Makefile uses sed -i 's/sudo //' Makefile Edit: once Vanilla-OS/apx#397 is merged this will be fixed. |
Hi, We have merged the Makefile PR upstream, can someone retrigger the failing jobs? |
I retriggered them, but there's now an error I don't understand on Edit: Nevermind, you've indeed specified Go 1.22 in |
for more information, see https://pre-commit.ci
Sorry, I assumed you were inactive, and I edited the pacscript to use Golang 1.22 |
ok my mistake, i will remove the line with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add
export PATH=/usr/lib/go-1.22/bin:${PATH}
To prepare()
, since Go 1.22 is not in PATH by default
Co-authored-by: V. <150687949+vigress8@users.noreply.github.com>
do i still need to add this line ? |
for more information, see https://pre-commit.ci
Yes |
because go 1.22 is not in the default path
it's still reporting that |
It's my mistake. That export should be done in |
for more information, see https://pre-commit.ci
thank you, i think it's more my mistake than yours, i wanted to help but it ended up by you @vigress8 doing all the work |
@souhaiebtar can you please make a PR that adds the line |
No description provided.