From 27ab5c0cc7f561eae78b4b600d6f5439ccb589d9 Mon Sep 17 00:00:00 2001 From: Kay Date: Mon, 21 Aug 2023 17:29:08 +0330 Subject: [PATCH] chore: remove gofmt and fix golang-ci version (#651) --- .github/workflows/gui.yml | 2 +- .github/workflows/linting.yml | 2 +- Makefile | 5 ++--- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/.github/workflows/gui.yml b/.github/workflows/gui.yml index 6cbaec281..2f0221163 100644 --- a/.github/workflows/gui.yml +++ b/.github/workflows/gui.yml @@ -30,7 +30,7 @@ jobs: run: make build_gui - name: Installing golangci-lint - run: go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest + run: go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.54.1 - name: Lint check run: BUILD_TAG=gtk make check diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index fa9840974..d83f756ed 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -23,7 +23,7 @@ jobs: uses: actions/checkout@v3 - name: Installing golangci-lint - run: go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest + run: go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.54.1 - name: Formatting and linting the project run: make check diff --git a/Makefile b/Makefile index 66bc21b5d..cfa42d5bd 100644 --- a/Makefile +++ b/Makefile @@ -15,7 +15,7 @@ all: build test ### Tools needed for development devtools: @echo "Installing devtools" - go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest + go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.54.1 go install github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-grpc-gateway@v2.12 go install github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2@v2.12 go install google.golang.org/protobuf/cmd/protoc-gen-go@v1.28 @@ -58,9 +58,8 @@ proto: cd www/grpc/ && statik -m -f -src swagger-ui/ ######################################## -### Formatting, linting, and vetting +### Formatting the code fmt: - gofmt -s -w . gofumpt -l -w . check: