test: add test for calculateFee GRPC

state/mock.go

@@ -211,6 +211,6 @@ func (m *MockState) Params() param.Params {
 	return m.TestParams
 }
 
-func (m *MockState) CalcFee(amount int64, payloadType payload.Type) (int64, error) {
+func (m *MockState) CalcFee(_ int64, payloadType payload.Type) (int64, error) {
 	return 0, nil
 }

state/state_test.go

@@ -18,6 +18,7 @@ import (
 	"github.com/pactus-project/pactus/types/tx/payload"
 	"github.com/pactus-project/pactus/types/validator"
 	"github.com/pactus-project/pactus/util"
+	"github.com/pactus-project/pactus/util/errors"
 	"github.com/pactus-project/pactus/util/testsuite"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -728,3 +729,37 @@ func TestCommittingInvalidBlock(t *testing.T) {
 	// It is possible that the same block would be considered valid by td.state2.
 	assert.Error(t, td.state1.CommitBlock(2, b, c))
 }
+
+func TestCalcFee(t *testing.T) {
+	td := setup(t)
+	tests := []struct {
+		amount          int64
+		fee             int64
+		expectedFee     int64
+		expectedErrCode int
+	}{
+		{1, 1, td.state1.params.MinimumFee, errors.ErrInvalidFee},
+		{1, 1001, td.state1.params.MinimumFee, errors.ErrInvalidFee},
+		{1, 1000, td.state1.params.MinimumFee, errors.ErrNone},
+
+		{1 * 1e9, 1, 100000, errors.ErrInvalidFee},
+		{1 * 1e9, 100001, 100000, errors.ErrInvalidFee},
+		{1 * 1e9, 100000, 100000, errors.ErrNone},
+
+		{1 * 1e12, 1, 1000000, errors.ErrInvalidFee},
+		{1 * 1e12, 1000001, 1000000, errors.ErrInvalidFee},
+		{1 * 1e12, 1000000, 1000000, errors.ErrNone},
+	}
+	for _, test := range tests {
+		fee, err := td.state2.CalcFee(int64(test.amount), payload.PayloadTypeTransfer)
+		assert.NoError(t, err)
+		assert.Equal(t, int64(test.expectedFee), fee)
+
+		fee, err = td.state2.CalcFee(int64(test.amount), payload.PayloadTypeUnbond)
+		assert.NoError(t, err)
+		assert.Equal(t, int64(0), fee)
+
+		_, err = td.state2.CalcFee(int64(test.amount), 6)
+		assert.Error(t, err)
+	}
+}

wallet/client.go

@@ -93,5 +93,4 @@ func (c *grpcClient) getFee(amount int64, payloadType payload.Type) (int64, erro
 		return 0, err
 	}
 	return res.Fee, nil
-
 }

wallet/client_test.go

@@ -78,7 +78,13 @@ func (s *transactionServer) GetTransaction(_ context.Context,
 }
 
 func (s *transactionServer) CalculateFee(_ context.Context,
-	req *pactus.CalculateFeeRequest) (*pactus.CalculateFeeResponse, error) {
+	_ *pactus.CalculateFeeRequest) (*pactus.CalculateFeeResponse, error) {
+
+	return &pactus.CalculateFeeResponse{Fee: 0}, nil
+}
+
+func (s *transactionServer) GetFee(_ context.Context,
+	_ *pactus.CalculateFeeRequest) (*pactus.CalculateFeeResponse, error) {
 
 	return &pactus.CalculateFeeResponse{Fee: 0}, nil
 }

wallet/tx_builder.go

@@ -97,7 +97,10 @@ func (m *txBuilder) build() (*tx.Tx, error) {
 		return nil, err
 	}
 
-	m.setFee()
+	err = m.setFee()
+	if err != nil {
+		return nil, err
+	}
 
 	var trx *tx.Tx
 	switch m.typ {

www/grpc/transaction.go

@@ -68,6 +68,7 @@ func (s *transactionServer) CalculateFee(_ context.Context,
 	if err != nil {
 		return nil, err
 	}
+
 	return &pactus.CalculateFeeResponse{
 		Fee: fee,
 	}, nil