Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new API to get Public key by address #449

Closed
b00f opened this issue Apr 26, 2023 · 5 comments · Fixed by #704
Closed

Adding new API to get Public key by address #449

b00f opened this issue Apr 26, 2023 · 5 comments · Fixed by #704
Assignees
Labels

Comments

@b00f
Copy link
Collaborator

b00f commented Apr 26, 2023

Describe the problem

Recently, we have indexed public keys by their addresses: #437
This helps reduce the size of blocks by removing duplicated public keys. Now, we can add a new API in gRPC to get the public key associated with a specific address.

Ideal Solution

We should add a new RPC function named GetPublicKey in blockchain.proto. It will accept an address as input and return the corresponding Public Key as output. If the public key is not indexed yet, it can return a NotFound error.

@kehiy kehiy changed the title Adding new API to get Publick key by address Adding new API to get Public key by address Jul 9, 2023
@kehiy
Copy link
Contributor

kehiy commented Jul 9, 2023

I will work on this

@kehiy kehiy self-assigned this Jul 9, 2023
@b00f
Copy link
Collaborator Author

b00f commented Jul 10, 2023

I will work on this

This issue depends on #437. Please wait until that pull request is merged.

@kehiy
Copy link
Contributor

kehiy commented Sep 12, 2023

@b00f indexing pubkey is merged now.
what we can do with this issue?

@b00f
Copy link
Collaborator Author

b00f commented Sep 12, 2023

yes, now we can fix this issue.

@b00f
Copy link
Collaborator Author

b00f commented Sep 14, 2023

Don't forget to add this API to grpc-gateway.config.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants