fix(genesis): separate genesis param and chain param #1458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b00f
requested changes
Aug 7, 2024
b00f
requested changes
Aug 9, 2024
|
@b00f requested changes are done. but I can't make fee parameters private in genesis params since we will get linter errors. |
b00f
approved these changes
Aug 10, 2024
b00f
reviewed
Aug 11, 2024
| @@ -41,7 +42,7 @@ type Node struct { | |||
| nanomsg *nanomsg.Server | |||
| } | |||
|
|
|||
| func NewNode(genDoc *genesis.Genesis, conf *config.Config, | |||
| func NewNode(genDoc *genesis.Genesis, chainParam *param.Params, conf *config.Config, | |||
There was a problem hiding this comment.
Why did you pass params when you can get it from genesis?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue