Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(util): chunked download to improve download speed #1459

Merged
merged 5 commits into from
Aug 11, 2024

Conversation

Ja7ad
Copy link
Contributor

@Ja7ad Ja7ad commented Aug 6, 2024

Description

Improved download speed with chunk download.

Related issue(s)

@Ja7ad Ja7ad requested a review from b00f August 6, 2024 09:35
Copy link
Contributor

@maxipaz maxipaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left some minor comments

util/downloader/chunk.go Outdated Show resolved Hide resolved
util/downloader/chunk.go Show resolved Hide resolved
util/downloader/chunk.go Show resolved Hide resolved
util/downloader/downloader.go Outdated Show resolved Hide resolved
util/downloader/downloader.go Show resolved Hide resolved
util/downloader/downloader.go Outdated Show resolved Hide resolved
util/downloader/chunk_test.go Show resolved Hide resolved
util/downloader/err.go Outdated Show resolved Hide resolved
util/downloader/chunk.go Outdated Show resolved Hide resolved
util/downloader/chunk.go Outdated Show resolved Hide resolved
util/downloader/chunk_test.go Outdated Show resolved Hide resolved
util/downloader/downloader.go Show resolved Hide resolved
util/downloader/downloader.go Outdated Show resolved Hide resolved
util/downloader/downloader.go Show resolved Hide resolved
util/downloader/downloader.go Outdated Show resolved Hide resolved
util/downloader/downloader.go Outdated Show resolved Hide resolved
@b00f b00f changed the title fix(util): add chunk download way for improve download speed fix(util): chunked download to improve download speed Aug 9, 2024
Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 64.93506% with 27 lines in your changes missing coverage. Please review.

Project coverage is 75.40%. Comparing base (3a9a3be) to head (ac7bd6a).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1459      +/-   ##
==========================================
+ Coverage   75.30%   75.40%   +0.09%     
==========================================
  Files         220      225       +5     
  Lines       11472    11671     +199     
==========================================
+ Hits         8639     8800     +161     
- Misses       2413     2446      +33     
- Partials      420      425       +5     

@b00f b00f merged commit aee4482 into pactus-project:main Aug 11, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downloader should be able to download files in chunks
3 participants